Avoid pointer arithmetic with (void *) pointers #644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
October 20, 2015 13:02
Used for platforms where none of posix_memalign(), memalign() and _aligned_malloc() is available.
Conflicts: src/lib/openjp2/opj_malloc.c
|
Exact, I forgot about this & got no warning on my compiler... Difference is only valid for 2 non void* pointers of the same type. |
mayeut
added a commit
that referenced
this pull request
Oct 21, 2015
Avoid pointer arithmetic with (void *) pointers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Taking the difference of two void * pointers is not defined according to the C specification, and for example the z/OS compiler warns:
./opj_malloc.c:169 Operation between types
void*andvoid*is not allowed.