Fix unsigned int overflow reported by UBSan #761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Please add -DOPJ_UBSAN_BUILD to CFLAGS when building with -fsanitize=undefined,unsigned-integer-overflow It seems clang/gcc do not allow to disable checking for block of code other than function or file.
|
I missed this. Now the nightly dashboard submission from dora.c-s.fr for ubsan will include this -DOPJ_UBSAN_BUILD (both gcc and clang). Though I'm not sure to understand why we end up in the assert while the file should be rejected (should openpeg fail earlier ?). Also I don't understand the your comment "It seems clang/gcc do not allow to disable checking for block of code other than function or file." : opj_bio_read/write get inlined so the OPJ_NOSANITIZE() does not work ? |
rouault
added a commit
that referenced
this pull request
Jun 17, 2017
Remove OPJ_NOSANITIZE in opj_bio_read() and opj_bio_write() (#761)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please add -DOPJ_UBSAN_BUILD to CFLAGS when building with
-fsanitize=undefined,unsigned-integer-overflow
It seems clang/gcc do not allow to disable checking for block of code
other than function or file.
Update #718