Implement predictive termination check #800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rouault
changed the title
rouault
force-pushed
the
tier1_optimizations_multithreading_pterm_check
branch
from
c9f3d88
to
42e938e
Compare
|
Note: this PR has now been rebased on-top current master after merge of #786 |
rouault
force-pushed
the
tier1_optimizations_multithreading_pterm_check
branch
from
42e938e
to
507224b
Compare
…enabled and emit a warning when errors are found
rouault
force-pushed
the
tier1_optimizations_multithreading_pterm_check
branch
from
507224b
to
94c4b73
Compare
|
Merging. Doesn't impact performance in a measurable way when decoding MAPA.jp2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements (on top of #786) checking of code stream errors when predictable termination is enabled. Warning are emitted when errors are found. To be honest, I came with the numerical values used by those checks in a rather experimental way by running it on a set of good and corrupted images.
The relevant commit is c9f3d88