build both shared and static library #954
Conversation
src/lib/openjp2/CMakeLists.txt
Outdated
| @@ -87,7 +87,9 @@ if(WIN32) | |||
| add_definitions(-DOPJ_STATIC) | |||
| endif() | |||
| endif() | |||
| add_library(${OPENJPEG_LIBRARY_NAME} ${OPENJPEG_SRCS}) | |||
| add_library(${OPENJPEG_LIBRARY_NAME} SHARED ${OPENJPEG_SRCS}) | |||
| add_library(openjp2_static STATIC ${OPENJPEG_SRCS}) | |||
There was a problem hiding this comment.
Any reason not use ${OPENJPEG_LIBRARY_NAME} as well ? Generally both static and dynamic library have the same basename.
There was a problem hiding this comment.
cmake doesn't allow for duplicate target name I think
There was a problem hiding this comment.
https://stackoverflow.com/questions/2152077/is-it-possible-to-get-cmake-to-build-both-a-static-and-shared-version-of-the-sam and https://datainfer.wordpress.com/2013/10/24/make-both-static-and-shared-libraries-in-one-build-with-cmake/ give one hint how to do that with set_target_properties(MyLibStatic PROPERTIES OUTPUT_NAME MyLib), but this one must be restricted to non-Windows platform, as Windows apparently need different names.
There was a problem hiding this comment.
Yes the PR already uses the set_target_properties.
|
Fails to build on Windows : http://my.cdash.org/buildSummary.php?buildid=1229211 |
|
OK let me condition this on Non windows. |
|
Thanks, can you try again? |
|
Ping? This should be good to go. Thanks for reviewing! |
This enabled building a static library, in addition to a shared one. I need this myself for building standalone applications, but I think it is generally useful.
Thank you for your review.