Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Possible bug - ObservablePattern is not a subclass of Pattern #543

Closed
10 tasks done
ajnelson-nist opened this issue Jul 21, 2023 · 5 comments · Fixed by #560
Closed
10 tasks done

Possible bug - ObservablePattern is not a subclass of Pattern #543

ajnelson-nist opened this issue Jul 21, 2023 · 5 comments · Fixed by #560
Labels
bug question
Milestone
UCO 2.0.0

Comments

@ajnelson-nist
Copy link
Contributor

ajnelson-nist commented Jul 21, 2023 •
edited

Bug description

While reviewing subclasses of observable:Observable, I came across observable:ObservablePattern, which only has one superclass, observable:Observable.

Was this class intended to be a subclass of pattern:Pattern?

Steps to reproduce

The subclassing statement in UCO 1.2.0 is here.

Coordination

  • Tracking in Jira ticket OC-297
  • Administrative review completed, proposal announced to Ontology Committees (OCs) on 2023-11-09
  • Solution announced to OCs on 2023-11-09
  • Solutions development phase completed. (N/A - bugfix)
  • Backwards-compatible implementation merged into develop for the next release (N/A)
  • develop state with backwards-compatible implementation merged into develop-2.0.0 (N/A)
  • Backwards-incompatible implementation merged into develop-2.0.0
  • Milestone linked
  • Documentation logged in pending release page
  • Prerelease publication: CASE develop branch updated to track UCO's updated develop branch (N/A)
  • Prerelease publication: CASE develop-2.0.0 branch updated to track UCO's updated develop-2.0.0 branch
@ajnelson-nist ajnelson-nist mentioned this issue Jul 21, 2023
Closed
14 tasks
@ajnelson-nist
Copy link
Contributor Author

@sbarnum , do you have an answer on whether this was a bug?

Absent a reply, this will be discussed in the Ontology Committees meeting on 2023-08-29.

@ajnelson-nist
Copy link
Contributor Author

@sbarnum confirmed on today's call - this was an oversight/bug.

@ajnelson-nist ajnelson-nist added this to the UCO 1.3.0 milestone Aug 29, 2023
@ajnelson-nist
Copy link
Contributor Author

I think as a structural change, this would be backwards-incompatible and would need to target UCO 2.0.0.

@ajnelson-nist ajnelson-nist modified the milestones: UCO 1.3.0, UCO 2.0.0 Oct 26, 2023
ajnelson-nist added a commit that referenced this issue Nov 9, 2023
@ajnelson-nist
Designate ObservablePattern a subclass of Pattern, adding namespace i…
d5ad31f 
…mport

This patch also has the Observable namespace import the Pattern
namespace, to attain first access to the Pattern class.

No effects were observed on Make-managed files.

References:
* #543

Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
@ajnelson-nist ajnelson-nist mentioned this issue Nov 9, 2023
Merged
13 tasks
@ajnelson-nist
Copy link
Contributor Author

PR 560 has been posted as a resolution to this confirmed bug.

Note that the implementation had a non-trivial side effect of inducing the Observable namespace to import the Pattern namespace.

Because this was more than adding a subclass designation, I would prefer to handle this as a fast-track change proposal.

@ajnelson-nist ajnelson-nist linked a pull request Nov 9, 2023 that will close this issue
Issue 543: Designate ObservablePattern a subclass of Pattern, adding namespace import #560
Merged
13 tasks
ajnelson-nist added a commit that referenced this issue Nov 9, 2023
@ajnelson-nist
Revert direct Pattern namespace import
885acb5 
The previous patch included a direct Pattern namespace import.  This
turns out to not be necessary because the Pattern namespace is already
in the transitive `owl:imports` closure, via the Action namespace.
Hence, the `Pattern` class is already available for `ObservablePattern`.

I realized this when I noticed the `catalog-v001.xml` file didn't
require an update from adding the direct import.

References:
* #543

Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
ajnelson-nist added a commit to casework/CASE-Archive that referenced this issue Nov 9, 2023
@ajnelson-nist
Bump UCO unstable-2.0.0 pointer
6e89872 
No effects were observed on Make-managed files.

References:
* ucoProject/UCO#543

Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
ajnelson-nist added a commit to casework/casework.github.io that referenced this issue Nov 9, 2023
@ajnelson-nist
Bump prerelease pointer
75543b4 
A follow-on patch will regenerate Make-managed files.

References:
* ucoProject/UCO#543

Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
ajnelson-nist added a commit to casework/casework.github.io that referenced this issue Nov 9, 2023
@ajnelson-nist
Regenerate Make-managed files
c264800 
References:
* ucoProject/UCO#543

Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
ajnelson-nist added a commit to casework/CASE-Examples that referenced this issue Nov 9, 2023
@ajnelson-nist
Bump unstable-2.0.0 pointer
91c7f81 
No effects were observed on Make-managed files.

References:
* ucoProject/UCO#543

Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
ajnelson-nist added a commit to casework/CASE-Corpora that referenced this issue Nov 9, 2023
@ajnelson-nist
Bump unstable-2.0.0 pointer
a11701f 
No effects were observed on Make-managed files.

References:
* ucoProject/UCO#543

Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
@ajnelson-nist
Copy link
Contributor Author

PR 560 has been posted as a resolution to this confirmed bug.

Note that the implementation had a non-trivial side effect of inducing the Observable namespace to import the Pattern namespace.

Because this was more than adding a subclass designation, I would prefer to handle this as a fast-track change proposal.

This turned out to not be the case. The transitive import closure for the Observable namespace was not affected; ontology/uco/observable/catalog-v001.xml already notes that the Pattern namespace is in the transitive import closure.

The impact of this proposal is reduced back to being addition of a single triple, so it is now being treated the bugfix review workflow, for UCO 2.0.0.

ajnelson-nist added a commit to casework/CASE-Archive that referenced this issue Nov 22, 2023
@ajnelson-nist
Bump UCO unstable-2.0.0 pointer
e70885f 
No effects were observed on Make-managed files.

References:
* ucoProject/UCO#543

Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
ajnelson-nist added a commit to casework/casework.github.io that referenced this issue Nov 22, 2023
@ajnelson-nist
Bump prerelease pointer
e5b3212 
No effects were observed on Make-managed files.

References:
* ucoProject/UCO#543

Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
ajnelson-nist added a commit to casework/CASE-Corpora that referenced this issue Nov 22, 2023
@ajnelson-nist
Bump unstable pointers
077bde3 
No effects were observed on Make-managed files.

References:
* ucoProject/UCO#543

Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
ajnelson-nist added a commit to casework/CASE-Examples that referenced this issue Nov 22, 2023
@ajnelson-nist
Bump unstable pointer
dbee8e6 
No effects were observed on Make-managed files.

References:
* ucoProject/UCO#543

Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
ajnelson-nist added a commit to ucoProject/ucoproject.github.io that referenced this issue Nov 22, 2023
@ajnelson-nist
Add documentation for Issue 543
42d66be 
References:
* ucoProject/UCO#543

Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
ajnelson-nist added a commit to casework/CASE that referenced this issue Nov 22, 2023
@ajnelson-nist
Bump UCO to current state of develop-2.0.0
2d54184 
No effects were observed on Make-managed files.

References:
* ucoProject/UCO#543

Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
@ajnelson-nist ajnelson-nist mentioned this issue Nov 22, 2023
Merged
ajnelson-nist added a commit to casework/casework.github.io that referenced this issue Nov 28, 2023
@ajnelson-nist
Bump prerelease pointers
2e4759e 
A follow-on patch will regenerate Make-managed files.

References:
* ucoProject/UCO#543

Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
ajnelson-nist added a commit to casework/casework.github.io that referenced this issue Nov 28, 2023
@ajnelson-nist
Regenerate Make-managed files
15ddcd0 
References:
* ucoProject/UCO#543

Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
ajnelson-nist added a commit to casework/CASE-Examples that referenced this issue Nov 28, 2023
@ajnelson-nist
Bump unstable pointers
70facc8 
No effects were observed on Make-managed files.

References:
* ucoProject/UCO#543

Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
ajnelson-nist added a commit to casework/CASE-Corpora that referenced this issue Nov 28, 2023
@ajnelson-nist
Bump unstable pointers
94ee1de 
No effects were observed on Make-managed files.

References:
* ucoProject/UCO#543

Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug question
Projects
None yet
Milestone
UCO 2.0.0
Development

Successfully merging a pull request may close this issue.

Issue 543: Designate ObservablePattern a subclass of Pattern, adding namespace import ucoProject/UCO
1 participant
@ajnelson-nist