Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Possible bug - ActionLifecycle is not a subclass of ActionPattern #556

Closed
7 tasks done
ajnelson-nist opened this issue Oct 26, 2023 · 4 comments · Fixed by #578
Closed
7 tasks done

Possible bug - ActionLifecycle is not a subclass of ActionPattern #556

ajnelson-nist opened this issue Oct 26, 2023 · 4 comments · Fixed by #578
Labels
bug Change Proposal
Milestone
UCO 2.0.0

Comments

@ajnelson-nist
Copy link
Contributor

ajnelson-nist commented Oct 26, 2023 •
edited

Bug description

Quoting @sbarnum in this comment:

action:ActionLifecycle is currently a subClass of action:Action which is appropriate but it should also be a subClass of action:ActionPattern.

Steps to reproduce

Lines 292--294 of 1.2.0's action.ttl seem to confirm the bug description:

	rdfs:subClassOf action:Action ;
	rdfs:label "ActionLifecycle"@en ;
	rdfs:comment "An action lifecycle is an action pattern consisting of an ordered set of multiple actions or subordinate action lifecycles."@en ;

Coordination

  • Tracking in Jira ticket OC-304
  • Administrative review completed, proposal announced to Ontology Committees (OCs) on 2024-01-18
  • Solutions Approval to be discussed in OC meeting, 2024-01-18
  • Solutions development phase completed.
  • Backwards-incompatible implementation merged into develop-2.0.0
  • Milestone linked
  • Documentation logged in pending release page
  • Prerelease publication: CASE develop-2.0.0 branch updated to track UCO's updated develop-2.0.0 branch
@ajnelson-nist
Copy link
Contributor Author

I think as a structural change, this would be backwards-incompatible and would need to target UCO 2.0.0.

@ajnelson-nist ajnelson-nist added this to the UCO 2.0.0 milestone Oct 26, 2023
@ajnelson-nist
Copy link
Contributor Author

From discussion on today's call, we believe the subclassing should be added/restored.

@ajnelson-nist
Copy link
Contributor Author

I intend to process this as a bugfix proposal, not requiring a Solutions Approval vote. If there are any objections, please post them here before Monday, 2024-01-22.

@ajnelson-nist
Copy link
Contributor Author

Clarification: This will be a bugfix Pull Request against the develop-2.0.0 branch.

ajnelson-nist added a commit that referenced this issue Jan 22, 2024
@ajnelson-nist
Designate ActionLifecycle a subclass of ActionPattern
e017e87 
No effects were observed on Make-managed files.

References:
* #556

Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
@ajnelson-nist ajnelson-nist mentioned this issue Jan 22, 2024
Merged
13 tasks
@ajnelson-nist ajnelson-nist linked a pull request Jan 22, 2024 that will close this issue
Issue 556: Designate ActionLifecycle a subclass of ActionPattern #578
Merged
13 tasks
ajnelson-nist added a commit to casework/CASE-Archive that referenced this issue Jan 22, 2024
@ajnelson-nist
Bump UCO to current state of unstable-2.0.0
3f88c4c 
No effects were observed on Make-managed files.

References:
* ucoProject/UCO#556

Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
ajnelson-nist added a commit to casework/casework.github.io that referenced this issue Jan 22, 2024
@ajnelson-nist
Bump unstable pointer
d52c0ca 
A follow-on patch will regenerate Make-managed files.

References:
* ucoProject/UCO#556

Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
ajnelson-nist added a commit to casework/casework.github.io that referenced this issue Jan 22, 2024
@ajnelson-nist
Regenerate Make-managed files
2aae18a 
References:
* ucoProject/UCO#556

Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
ajnelson-nist added a commit to casework/CASE-Examples that referenced this issue Jan 22, 2024
@ajnelson-nist
Bump unstable pointer
52ffe10 
No effects were observed on Make-managed files.

References:
* ucoProject/UCO#556

Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
ajnelson-nist added a commit to casework/CASE-Corpora that referenced this issue Jan 22, 2024
@ajnelson-nist
Bump unstable pointer
2ed3bb6 
No effects were observed on Make-managed files.

References:
* ucoProject/UCO#556

Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
ajnelson-nist added a commit to casework/CASE-Archive that referenced this issue Jan 30, 2024
@ajnelson-nist
Bump UCO to current state of unstable-2.0.0
dee1b61 
No effects were observed on Make-managed files.

References:
* ucoProject/UCO#556

Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
ajnelson-nist added a commit to casework/casework.github.io that referenced this issue Jan 30, 2024
@ajnelson-nist
Bump unstable-2.0.0 pointer
3f85336 
No effects were observed on Make-managed files.

References:
* ucoProject/UCO#556

Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
ajnelson-nist added a commit to casework/CASE that referenced this issue Feb 1, 2024
@ajnelson-nist
Bump UCO to updated state of unstable-2.0.0
30b14d5 
No effects were observed on Make-managed files.

References:
* ucoProject/UCO#556

Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
@ajnelson-nist ajnelson-nist mentioned this issue Feb 1, 2024
Merged
ajnelson-nist added a commit to casework/casework.github.io that referenced this issue Feb 2, 2024
@ajnelson-nist
Bump unstable-2.0.0 pointer
f4473c7 
No effects were observed on Make-managed files.

References:
* ucoProject/UCO#556

Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
ajnelson-nist added a commit to casework/CASE-Corpora that referenced this issue Feb 2, 2024
@ajnelson-nist
Bump unstable-2.0.0 pointer
dad920c 
No effects were observed on Make-managed files.

References:
* ucoProject/UCO#556

Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
ajnelson-nist added a commit to casework/CASE-Examples that referenced this issue Feb 2, 2024
@ajnelson-nist
Bump unstable-2.0.0 pointer
6d8456d 
No effects were observed on Make-managed files.

References:
* ucoProject/UCO#556

Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
ajnelson-nist added a commit to casework/casework.github.io that referenced this issue Feb 2, 2024
@ajnelson-nist
Bump develop-2.0.0 pointer
823594b 
A follow-on patch will regenerate Make-managed files.

References:
* ucoProject/UCO#556

Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
ajnelson-nist added a commit to casework/casework.github.io that referenced this issue Feb 2, 2024
@ajnelson-nist
Regenerate Make-managed files
e4f67bd 
References:
* ucoProject/UCO#556

Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
ajnelson-nist added a commit to ucoProject/ucoproject.github.io that referenced this issue Feb 2, 2024
@ajnelson-nist
Add documentation for Issue 556
ff2efbc 
References:
* ucoProject/UCO#556

Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
ajnelson-nist added a commit to casework/CASE-Corpora that referenced this issue Feb 5, 2024
@ajnelson-nist
Bump develop-2.0.0 pointer
6250da1 
No effects were observed on Make-managed files.

References:
* ucoProject/UCO#556

Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
ajnelson-nist added a commit to casework/CASE-Examples that referenced this issue Feb 5, 2024
@ajnelson-nist
Bump develop-2.0.0 pointer
bdca3de 
No effects were observed on Make-managed files.

References:
* ucoProject/UCO#556

Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Change Proposal
Projects
None yet
Milestone
UCO 2.0.0
Development

Successfully merging a pull request may close this issue.

Issue 556: Designate ActionLifecycle a subclass of ActionPattern ucoProject/UCO
1 participant
@ajnelson-nist