Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update change request template #579

Merged
merged 1 commit into from
Jan 23, 2024
Merged

Conversation

ajnelson-nist
Copy link
Contributor

This Pull Request updates GitHub templating. As a matter of GitHub interface programming, committee review is not required.

Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
@ajnelson-nist ajnelson-nist added this to the UCO 1.3.0 milestone Jan 22, 2024
@ajnelson-nist ajnelson-nist changed the base branch from master to develop January 22, 2024 23:35
@ajnelson-nist ajnelson-nist marked this pull request as ready for review January 22, 2024 23:36
@plbt5
Copy link
Contributor

plbt5 commented Jan 23, 2024

Although I'm fine with the text, wouldn't it be more efficient to turn around the proof of acceptance:

  • either include a checked checkmark placed before the text, or
  • simply include the text into the template
    This implies that requesters should remove the acceptance as opposed to include it.

@ajnelson-nist
Copy link
Contributor Author

@plbt5 : Checkmarks have an odd effect on the GitHub interface - they're interpreted as tasks to complete, so somewhat enact a requirement on the user. This was intended to be an opt-in request from the Ontology Committee to the posting user.

GitHub Markdown also doesn't appear to support radio buttons at the moment; I'd put a pair of those in if the technical option were available.

@kchason kchason merged commit da8aa53 into develop Jan 23, 2024
1 check passed
@kchason kchason deleted the update_change_request_template branch January 23, 2024 14:57
ajnelson-nist added a commit to casework/CASE that referenced this pull request Jan 23, 2024
No effects were observed on Make-managed files.

References:
* ucoProject/UCO#579

Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
ajnelson-nist added a commit to casework/CASE that referenced this pull request Jan 23, 2024
This ports the patch from UCO PR 579.

References:
* ucoProject/UCO#579

Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
ajnelson-nist added a commit to casework/CASE-Archive that referenced this pull request Jan 24, 2024
No effects were observed on Make-managed files.

References:
* ucoProject/UCO#579

Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
ajnelson-nist added a commit to casework/CASE-Archive that referenced this pull request Jan 24, 2024
No effects were observed on Make-managed files.

References:
* ucoProject/UCO#579

Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
ajnelson-nist added a commit to casework/casework.github.io that referenced this pull request Jan 24, 2024
No effects were observed on Make-managed files.

References:
* ucoProject/UCO#579

Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
ajnelson-nist added a commit to casework/CASE-Examples that referenced this pull request Jan 24, 2024
No effects were observed on Make-managed files.

References:
* ucoProject/UCO#579

Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
ajnelson-nist added a commit to casework/CASE-Corpora that referenced this pull request Jan 24, 2024
No effects were observed on Make-managed files.

References:
* ucoProject/UCO#579

Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants