Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: test/mig.shared.localfile #57

Closed
wants to merge 1 commit into from

Conversation

albu-diku
Copy link

Start putting together LocalFile tests and focus first on locking.

@jonasbardino
Copy link
Contributor

While coverage is always good, please don't spend too much time on localfile or the other localX and distX. They're hardly used anymore if at all and should probably either be retired or completely rewritten based on the catch-all shared.fileio. The same applies for iobase I think, but you can check e.g. with the codegrep.py helper or regular grep.

Good targets for unit testing from mig.shared include base, safeinput, serial, userdb, configuration, logger and validstring for starters. After those I think the accountstate, pwcrypto, vgrid, vgridaccess and perhaps the entire griddaemons subdir may be nice continuation targets to look into.

@jonasbardino jonasbardino added the enhancement New feature or request label May 25, 2024
@albu-diku albu-diku closed this Jun 7, 2024
@albu-diku albu-diku deleted the test/mig.shared.localfile branch June 7, 2024 09:37
@albu-diku
Copy link
Author

Replaced by #66.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants