Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Root fix injection mode misses impacted paramaters #71

Open
nimakarimipour opened this issue Sep 15, 2022 · 0 comments · May be fixed by #72
Open

Root fix injection mode misses impacted paramaters #71

nimakarimipour opened this issue Sep 15, 2022 · 0 comments · May be fixed by #72
Assignees
@nimakarimipour
Labels
bug Something isn't working

Comments

@nimakarimipour
Copy link
Member

Describe the bug
If the mode for applying reports is Root Fix only, it will miss injections of @Nullable annotations on impacted parameters.

To Reproduce
Have method the flows nullability back to upstream in downstream dependency and have the mode set to Root Fix instead Chain fix.

Expected behavior
Annotate impacted parameters in all modes.

Stack trace
Not-Applicable.

OS (please complete the following information):

  • Annotator Version [e.g. v1.3.3-SNAPSHOT]

Additional context
Not-Applicable.
@nimakarimipour nimakarimipour added the bug Something isn't working label Sep 15, 2022
@nimakarimipour nimakarimipour self-assigned this Sep 15, 2022
nimakarimipour added a commit that referenced this issue Sep 15, 2022
@nimakarimipour
resolves #71
acad35b
@nimakarimipour nimakarimipour linked a pull request Sep 15, 2022 that will close this issue
Draft
nimakarimipour added a commit that referenced this issue Sep 17, 2022
@nimakarimipour
resolve #71
44afe23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nimakarimipour nimakarimipour

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Resolves #71 including fixes from downstream depenedencies ucr-riple/NullAwayAnnotator
1 participant
@nimakarimipour