Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ilj - Switch section search & description search #14

Merged
merged 2 commits into from Nov 20, 2022

Conversation

tallyhawley
Copy link
Contributor

@tallyhawley tallyhawley commented Nov 18, 2022

Closes #3.

Switches the Section Search page and the Courses (Description) Search page.

The home page now shows the UCSB Section Search page:
Screen Shot 2022-11-17 at 6 13 25 PM

The nav bar now has a "Course Descriptions" drop down, with a "Search" option.
Screen Shot 2022-11-17 at 6 08 02 PM

When we click on "Search", we navigate to /coursedescriptions/search, which is the Description search page (formerly the Home page):
Screen Shot 2022-11-17 at 6 13 32 PM

(The logo/icon on the navbar does not load properly on localhost, but loads on Heroku).

All tests have been updated accordingly.

@andrewpengucsb andrewpengucsb added the FIXME: Peer CR Please get a peer code review label Nov 18, 2022
@tallyhawley tallyhawley added the f22-5pm-1 f22-5pm-1 label Nov 20, 2022
@ethanlee556 ethanlee556 temporarily deployed to f22-5pm-1-courses November 20, 2022 01:13 Inactive
ethanlee556
ethanlee556 previously approved these changes Nov 20, 2022
Copy link
Contributor

@ethanlee556 ethanlee556 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@pconrad pconrad force-pushed the ilj-switchSectionDescriptionSearch branch from 33214e5 to 0fc529c Compare November 20, 2022 08:10
@ethanlee556 ethanlee556 temporarily deployed to f22-5pm-1-courses November 20, 2022 15:34 Inactive
Copy link
Contributor

@ethanlee556 ethanlee556 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pconrad pconrad removed the FIXME: Peer CR Please get a peer code review label Nov 20, 2022
@pconrad pconrad temporarily deployed to f22-5pm-1-courses November 20, 2022 17:30 Inactive
Copy link
Contributor

@pconrad pconrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pconrad pconrad added the 10 10 pts label Nov 20, 2022
@pconrad pconrad merged commit 4778b95 into main Nov 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10 10 pts f22-5pm-1 f22-5pm-1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Swap the Section Search and the Description Search
6 participants