Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lpn - Stryker modifications #32

Closed
wants to merge 4 commits into from
Closed

lpn - Stryker modifications #32

wants to merge 4 commits into from

Conversation

liamjet
Copy link
Contributor

@liamjet liamjet commented Nov 23, 2022

Closes #23 .

Modifies the following files:

.github/workflows/30-frontend-tests.yml
.github/workflows/32-frontend-coverage.yml
.github/workflows/36-frontend-eslint.yml

.github/workflows/10-backend-unit.yml
.github/workflows/12-backend-jacoco.yml
.github/workflows/14-backend-pitest.yml

Copy link
Contributor

@tallyhawley tallyhawley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewpengucsb andrewpengucsb added the FIXME: Add Team Label Please add the label for your team, e.g. f22-4pm-3 label Nov 24, 2022
@pconrad pconrad added f22-5pm-1 f22-5pm-1 STAFF: ready for review green on CI, has peer CR, no other obvious issues and removed FIXME: Add Team Label Please add the label for your team, e.g. f22-4pm-3 labels Nov 25, 2022
@pconrad
Copy link
Contributor

pconrad commented Nov 26, 2022

This one appear now to be moot---those changes were already merged as part of another PR.

@pconrad pconrad added Moot? It appears the change that would have been made here are already in the code base and removed STAFF: ready for review green on CI, has peer CR, no other obvious issues labels Nov 26, 2022
@liamjet
Copy link
Contributor Author

liamjet commented Nov 28, 2022

Closing PR since someone else covered this somehow.

@liamjet liamjet closed this Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
f22-5pm-1 f22-5pm-1 Moot? It appears the change that would have been made here are already in the code base
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Limit stryker and other frontend testing to frontend directory; limit backend testing to src and related files
4 participants