Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LPN - copied Quarter files from old courses #42

Merged
merged 5 commits into from Nov 28, 2022
Merged

Conversation

liamjet
Copy link
Contributor

@liamjet liamjet commented Nov 28, 2022

Closes Issue #22 .

Now passes all tests. Ended up not using Professor Conrad's solution but it did help me a lot (I had to remove it to pass coverage tests when the main file was modified).

@pconrad pconrad added FIXME: Peer CR Please get a peer code review FIXME: Add Team Label Please add the label for your team, e.g. f22-4pm-3 5 5 pts labels Nov 28, 2022
@pconrad pconrad added the FIXME: CI/CD Failure One or more CI/CD checks is not green label Nov 28, 2022
@pconrad
Copy link
Contributor

pconrad commented Nov 28, 2022

ack.. when we wrote those files before, we had jacoco, but we didn't yet have Stryker! That can turn into a 10 points issue instead of a 5 point one if you can come up with tests for those last three mutations that survived. Should be straightforward!

@pconrad pconrad added 10 10 pts and removed 5 5 pts labels Nov 28, 2022
@liamjet liamjet added f22-5pm-1 f22-5pm-1 and removed FIXME: Add Team Label Please add the label for your team, e.g. f22-4pm-3 FIXME: CI/CD Failure One or more CI/CD checks is not green labels Nov 28, 2022
Copy link
Contributor

@Jameszhao1103 Jameszhao1103 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@liamjet liamjet added STAFF: ready for review green on CI, has peer CR, no other obvious issues and removed FIXME: Peer CR Please get a peer code review labels Nov 28, 2022
@pconrad pconrad removed the STAFF: ready for review green on CI, has peer CR, no other obvious issues label Nov 28, 2022
Copy link
Contributor

@pconrad pconrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I'm impressed that you were able to find a way to pass the pitest mutations!
I wasn't able to... so well done!

@pconrad pconrad merged commit 84b74ef into main Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10 10 pts f22-5pm-1 f22-5pm-1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants