Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Peter - Add PersonalSections Table to PersonalSchedulesDetails Page #49

Merged
merged 2 commits into from Nov 29, 2022

Conversation

hauntedghosts
Copy link
Contributor

@hauntedghosts hauntedghosts commented Nov 29, 2022

This pull request closes Issue #19 Add personal schedule details to PersonalScheduleDetailsPage.

Which files were modified / added?

modified:   src/main/pages/PersonalSchedules/PersonalSchedulesDetailsPage.js
modified:   src/tests/pages/PersonalSchedules/PersonalSchedulesDetailsPage.test.js

What does this pull request add?

  • Adds the Personal Sections Table component which lists all added courses to a personal schedule to the PersonalSchedule Details page.
  • Additionally, a test was created to ensure Personal sections table is rendered correctly on the PersonalSections Details page and works correctly.

How can this pull request be tested?

TESTING ON HEROKU QA

See (Deployed on Heroku): https://f22-5pm-2-courses.herokuapp.com/personalschedules/details/24

Results should look like this on Heroku:
Screenshot 2022-11-28 at 6 03 31 PM

Also to further test the feature, add more items to the table! To do this:

  • Go to UCSB Course Search and search for S22 courses in any department.
  • Find a course
  • Copy the enrollment code, navigate to PSCourse>Create
  • Paste the enrollment code and enter 24 into the Personal Schedule ID Field
  • Now, Go to PersonalSchedules>List>Details (ID24)
  • Verify that the new Sections have been added

LOCAL TESTING:

  • Pull this branch so you can access it locally.
  • mvn spring-boot:run
  • cd to the frontend directory in the project file
  • npm start
  • Navigate to http://localhost:8080/personalschedules/list
  • Check details of a Personal Schedule to see Sections
  • If empty, populate with steps in Testing in Heroku QA Section

Expected result when testing Locally:
Screenshot 2022-11-28 at 6 07 24 PM

@hauntedghosts hauntedghosts added the f22-5pm-2 f22-5pm-2 label Nov 29, 2022
@hauntedghosts hauntedghosts changed the title Add PersonalSections Table to PersonalSchedules details page, and add… Peter - Add PersonSections Table to PersonalSchedulesDetails Page Nov 29, 2022
@hauntedghosts hauntedghosts changed the title Peter - Add PersonSections Table to PersonalSchedulesDetails Page Peter - Add PersonalSections Table to PersonalSchedulesDetails Page Nov 29, 2022
@hauntedghosts hauntedghosts self-assigned this Nov 29, 2022
@hauntedghosts hauntedghosts linked an issue Nov 29, 2022 that may be closed by this pull request
@pconrad pconrad added the FIXME: Peer CR Please get a peer code review label Nov 29, 2022
@sophiacheng01 sophiacheng01 temporarily deployed to f22-5pm-2-courses November 29, 2022 03:27 Inactive
Copy link
Contributor

@sophiacheng01 sophiacheng01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sophiacheng01 sophiacheng01 added STAFF: ready for review green on CI, has peer CR, no other obvious issues and removed FIXME: Peer CR Please get a peer code review labels Nov 29, 2022
Copy link
Contributor

@bhuang01 bhuang01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pconrad pconrad temporarily deployed to f22-5pm-2-courses November 29, 2022 22:44 Inactive
Copy link
Contributor

@pconrad pconrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pconrad pconrad added 10 10 pts and removed STAFF: ready for review green on CI, has peer CR, no other obvious issues labels Nov 29, 2022
@pconrad pconrad merged commit 5fe7535 into main Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10 10 pts f22-5pm-2 f22-5pm-2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add personal schedule details to PersonalScheduleDetailsPage
4 participants