CS - Add frontend support for new job which takes only a quarter as its parameter #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drikdrok
changed the title
tallyhawley
force-pushed
the
ChristianSupportForNewQuarterJob
branch
from
8338cc7
to
a6437ee
Compare
liamjet
added
STAFF: ready for review
pconrad
added
FIXME: Changes Requested
pconrad
requested changes
Dec 4, 2022
|
|
||
| const quarters = quarterRange(startQtr, endQtr); | ||
|
|
||
| // Stryker disable all : not sure how to test/mock local storage |
There was a problem hiding this comment.
This should be followed by
// Stryker enable all
after the line of code that does local storage.
| callback({quarter}); | ||
| }; | ||
|
|
||
| // Stryker disable all : Stryker is testing by changing the padding to 0. But this is simply a visual optimization as it makes it look better |
There was a problem hiding this comment.
Same as above... it's ok to invoke this for the part of the code that needs Stryker disabled... but you need to confine this to the smallest possible scope.
There was a problem hiding this comment.
In #57 I suggest what this might look like.
…terJob-pc pc - make stryker exclusions as small as possible lgtm
pconrad
added
10
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #25
Storyboard: https://ucsb-cs156-f22.github.io/f22-5pm-courses-docs-qa/storybook-qa/ChristianSupportForNewQuarterJob/?path=/docs/components-jobs-updatecoursesbyquarterjobform--default