Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ic - Add function in jobs controller for milking the cows #2

Merged
merged 4 commits into from Nov 19, 2022

Conversation

irenecho75
Copy link
Contributor

@irenecho75 irenecho75 commented Nov 17, 2022

In this PR, we add a job for "milking the cows" to JobsController.java. Closes #12

akdas16
akdas16 previously approved these changes Nov 17, 2022
Copy link

@akdas16 akdas16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

xxzjh
xxzjh previously approved these changes Nov 17, 2022
Copy link

@xxzjh xxzjh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@irenecho75 irenecho75 dismissed stale reviews from xxzjh and akdas16 via acf8211 November 17, 2022 02:56
Copy link
Contributor

@pconrad pconrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pconrad pconrad added the f22-6pm-4 f22-6pm-4 label Nov 17, 2022
@pconrad pconrad temporarily deployed to f22-6pm-4-happycows November 17, 2022 03:12 Inactive
Copy link
Contributor

@pconrad pconrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change GET to POST for the milkjob

@irenecho75 irenecho75 dismissed pconrad’s stale review November 18, 2022 01:27

Fixed the get mapping to post mapping

@vivianross06
Copy link
Contributor

Please link this PR to an issue so that we can see what it closes out. You can do this in a comment by typing "Closes #" and selecting the relevant issue.

@irenecho75
Copy link
Contributor Author

Closes #12

@vivianross06
Copy link
Contributor

Looks like typing the comment regarding closing an issue only works when you put it in the initial description of a PR, not a comment. Please do that in the future. If you forget, you can add an issue by clicking on "development" in the menu on the right side of the page, and linking the correct issue there. Please do that for this PR!

Copy link
Contributor

@vivianross06 vivianross06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@pconrad pconrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Can you deploy this to qa so that I can test it before merging?

@irenecho75 irenecho75 temporarily deployed to f22-6pm-4-happycows-qa November 18, 2022 02:10 Inactive
@pconrad pconrad added Merge Candidate: Needs QA deploy Staff thinks this may be mergeable; needs to be tested on QA 5 5 pts and removed Merge Candidate: Needs QA deploy Staff thinks this may be mergeable; needs to be tested on QA labels Nov 18, 2022
@pconrad pconrad merged commit 4f1d774 into main Nov 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 5 pts f22-6pm-4 f22-6pm-4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a second "job" similar to the test job that will "Milk the cows".
5 participants