New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ic - Add function in jobs controller for milking the cows #2
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please change GET to POST for the milkjob
src/main/java/edu/ucsb/cs156/happiercows/controllers/JobsController.java
Outdated
Show resolved
Hide resolved
Fixed the get mapping to post mapping
Please link this PR to an issue so that we can see what it closes out. You can do this in a comment by typing "Closes #" and selecting the relevant issue. |
Closes #12 |
Looks like typing the comment regarding closing an issue only works when you put it in the initial description of a PR, not a comment. Please do that in the future. If you forget, you can add an issue by clicking on "development" in the menu on the right side of the page, and linking the correct issue there. Please do that for this PR! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Can you deploy this to qa so that I can test it before merging?
In this PR, we add a job for "milking the cows" to JobsController.java. Closes #12