Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jz - Remove "This game will end on" #40

Merged
merged 1 commit into from Nov 29, 2022
Merged

jz - Remove "This game will end on" #40

merged 1 commit into from Nov 29, 2022

Conversation

xxzjh
Copy link

@xxzjh xxzjh commented Nov 28, 2022

#39 remove the line "this game will end on"
Screen Shot 2022-11-28 at 12 29 59 AM

@xxzjh xxzjh added the f22-6pm-4 f22-6pm-4 label Nov 28, 2022
@xxzjh xxzjh linked an issue Nov 28, 2022 that may be closed by this pull request
REMOVE the "This game will end on" (5 pts) #39
Closed
@xxzjh xxzjh added the FIXME: Peer CR Please get a peer code review label Nov 29, 2022
irenecho75
irenecho75 previously approved these changes Nov 29, 2022
View reviewed changes
Copy link
Contributor

@irenecho75 irenecho75 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xxzjh xxzjh temporarily deployed to f22-6pm-4-happycows-qa November 29, 2022 02:19 Inactive
@irenecho75 irenecho75 added STAFF: ready for review green on CI, has peer CR, no other obvious issues and removed FIXME: Peer CR Please get a peer code review labels Nov 29, 2022
pconrad
pconrad approved these changes Nov 29, 2022
View reviewed changes
Copy link
Contributor

@pconrad pconrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pconrad pconrad added 5 5 pts and removed STAFF: ready for review green on CI, has peer CR, no other obvious issues labels Nov 29, 2022
@pconrad pconrad merged commit 126cd71 into main Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pconrad pconrad pconrad approved these changes

@irenecho75 irenecho75 irenecho75 left review comments

@akdas16 akdas16 Awaiting requested review from akdas16

@BenYangSB BenYangSB Awaiting requested review from BenYangSB

@shialanyu shialanyu Awaiting requested review from shialanyu

@singhvyom singhvyom Awaiting requested review from singhvyom

@andrewpengucsb andrewpengucsb Awaiting requested review from andrewpengucsb

@bzamora020 bzamora020 Awaiting requested review from bzamora020

@vivianross06 vivianross06 Awaiting requested review from vivianross06

Assignees
No one assigned
Labels
5 5 pts f22-6pm-4 f22-6pm-4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

REMOVE the "This game will end on" (5 pts)
3 participants
@xxzjh @pconrad @irenecho75