New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MK Implemented BasicCourseTableIndexPage and corresponding test #10
Conversation
5cd251c
to
aed3c1e
Compare
Everything looks great to me. LGTM. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR adds a new page, but there is no way to access this new page yet, so it can't be tested in the app.
But what you could do (and should do so that this can be tested), is to add a story for it in the storybook.
I've done that for you this time.
That way once this job finishes:
At the -docs-qa site, you'll have a link to the storybook entry that you can include in the PR description like this:
And this link takes you to the new page:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a storybook entry.. that's the only problem with the original PR. I took care of it for you this time to show how it's done; next time I'll ask the team to do it.
pc - update ci-cd to make sure jacoco and pitest coverage threshold i…
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
b478def
Implemented BasicCourseSearchIndexPage.js so that it can be moved from the homepage into a separate page clickable from the menu bar. Additionally, implemented a test for the index page, BasicCourseSearchIndexPage.test.js.
These will be used to close issue 9: Swap the Section Search and the Description Search, which @masonma21 is closing by adapting AppNavBar and App.js and AppNavBar test to reflect the swap of basic course description search (from the homepage) and section search (from the menu bar).
Passed all frontend tests:
Achieved Code Coverage: