Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A j footer source repo #13

Merged
merged 7 commits into from Nov 23, 2022
Merged

A j footer source repo #13

merged 7 commits into from Nov 23, 2022

Conversation

Abelatnafu
Copy link
Contributor

@Abelatnafu Abelatnafu commented Nov 19, 2022 •
edited

Abel & Junhwan Lee

  • Change the footer component so that it gets the value of the URL for the source repo from /api/systeminfo.

Screenshot 2022-11-18 at 9 05 32 PM

  • Modified tests on both backend and frontend.
  • Modified the fixtures for systemInfo.
  • Modified storybook to reflect the changes in the footer.

Screenshot 2022-11-18 at 9 04 53 PM

  • Added String sourceRepo to the SystemInfo class
  • Added initialization of this value from a property called app.sourceRepo in src/main/resources/application.properties.
  • Allowed that property to be overridden by an environment variable SOURCE_REPO
  • Made sure that the correct value is exposed by looking at the /api/systemInfo endpoint in Swagger.

Screenshot 2022-11-22 at 6 14 21 PM

@Abelatnafu Abelatnafu linked an issue Nov 19, 2022 that may be closed by this pull request
Modify footer to take value of source repo from /api/systemInfo instead of being hardcoded #8
Closed
@Abelatnafu Abelatnafu added the f22-7pm-1 f22-7pm-1 label Nov 19, 2022
@pconrad pconrad added the FIXME: Peer CR Please get a peer code review label Nov 19, 2022
@pconrad pconrad force-pushed the A-J-FooterSourceRepo branch 2 times, most recently from ead5027 to d4f068c Compare November 20, 2022 08:06
masonma21
masonma21 previously approved these changes Nov 21, 2022
View reviewed changes
Copy link
Contributor

@masonma21 masonma21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pconrad pconrad removed the FIXME: Peer CR Please get a peer code review label Nov 21, 2022
pconrad
pconrad requested changes Nov 21, 2022
View reviewed changes
Copy link
Contributor

@pconrad pconrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just one small nitpick (that you would have had no way of knowing, probably, but let's get this fixed before we merge it.)

frontend/src/main/utils/systemInfo.js Outdated Show resolved Hide resolved
frontend/src/main/utils/systemInfo.js Outdated Show resolved Hide resolved
frontend/src/tests/utils/systemInfo.test.js Outdated Show resolved Hide resolved
frontend/src/tests/utils/systemInfo.test.js Outdated Show resolved Hide resolved
src/main/java/edu/ucsb/cs156/courses/services/SystemInfoServiceImpl.java Outdated Show resolved Hide resolved
src/test/java/edu/ucsb/cs156/courses/controllers/SystemInfoControllerTests.java Show resolved Hide resolved
src/test/java/edu/ucsb/cs156/courses/controllers/SystemInfoControllerTests.java Show resolved Hide resolved
src/test/java/edu/ucsb/cs156/courses/controllers/SystemInfoControllerTests.java Show resolved Hide resolved
@pconrad pconrad added the FIXME: Changes Requested Please address the changes specified in the code review label Nov 21, 2022
@Abelatnafu Abelatnafu linked an issue Nov 23, 2022 that may be closed by this pull request
Add String sourceRepo to systeminfo #7
Closed
3 tasks
masonma21
masonma21 approved these changes Nov 23, 2022
View reviewed changes
Copy link
Contributor

@masonma21 masonma21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

pconrad
pconrad approved these changes Nov 23, 2022
View reviewed changes
Copy link
Contributor

@pconrad pconrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pconrad pconrad merged commit fb51999 into main Nov 23, 2022
@pconrad pconrad added 20 20 pts and removed FIXME: Changes Requested Please address the changes specified in the code review labels Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pconrad pconrad pconrad approved these changes

@masonma21 masonma21 masonma21 approved these changes

Assignees

@junhwanlee2316 junhwanlee2316

@Abelatnafu Abelatnafu

Labels
20 20 pts f22-7pm-1 f22-7pm-1
Projects
None yet
Milestone
No milestone
8 participants
@Abelatnafu @pconrad @masonma21 @AvishekDe @bzamora020 @vivianross06 @andrewpengucsb @junhwanlee2316