HY - PSCourse dropdown #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HansonYu23
requested review from
andrewpengucsb,
andysglez,
AvishekDe,
CalebL909,
DylanC1222,
EthanEpp,
mattn02 and
pconrad
pconrad
added
the
STAFF: ready for review
pconrad
approved these changes
Nov 27, 2022
| expect(axiosMock.history.post[0].params).toEqual( | ||
| { | ||
| "psId": "13", | ||
| "psId": "", |
There was a problem hiding this comment.
This is suspicious... why is this an empty string here?
I'll let it slide, but I think this might come back to bite you later.
so I want to encourage you to take a look
pconrad
added
10
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced Personal Schedule ID field in PSCourse create page with Personal schedule dropdown menu. Clicking "Create" when both a valid enrollment code is entered and a Personal schedule is selected calls api/courses/post for the entered values. Modified associated tests to account for changes.
Resolves #11