Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed "The game will end on" #41

Merged
merged 6 commits into from Nov 30, 2022
Merged

Removed "The game will end on" #41

merged 6 commits into from Nov 30, 2022

Conversation

FinalGale
Copy link
Contributor

@FinalGale FinalGale commented Nov 28, 2022 •
edited

This closes issue #39
image

blakerandle
blakerandle requested changes Nov 28, 2022
View reviewed changes
Copy link
Contributor

@blakerandle blakerandle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems the issue only wants to the remove the "This game will end on _." text, but the "Today is day _!" text is also removed in this PR. I think it should be added back

blakerandle
blakerandle reviewed Nov 28, 2022
View reviewed changes
Copy link
Contributor

@blakerandle blakerandle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes now lgtm. I understand the tests are failing due to the main branch's frontend tests failing, so this PR should probably be checked again after the main branch's tests are addressed and those fixes are merged into this branch.

RAILGUN1124
RAILGUN1124 approved these changes Nov 28, 2022
View reviewed changes
Copy link
Contributor

@RAILGUN1124 RAILGUN1124 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@pconrad pconrad added FIXME: CI/CD Failure One or more CI/CD checks is not green FIXME: Add Team Label Please add the label for your team, e.g. f22-4pm-3 FIXME: Changes Requested Please address the changes specified in the code review labels Nov 28, 2022
@RAILGUN1124 RAILGUN1124 added f22-7pm-4 f22-7pm-4 and removed FIXME: Add Team Label Please add the label for your team, e.g. f22-4pm-3 labels Nov 28, 2022
@FinalGale FinalGale temporarily deployed to f22-7pm-4-happycows-qa November 29, 2022 05:00 Inactive
blakerandle
blakerandle approved these changes Nov 29, 2022
View reviewed changes
Copy link
Contributor

@blakerandle blakerandle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@blakerandle blakerandle removed FIXME: Changes Requested Please address the changes specified in the code review FIXME: CI/CD Failure One or more CI/CD checks is not green labels Nov 30, 2022
@blakerandle blakerandle added the STAFF: ready for review green on CI, has peer CR, no other obvious issues label Nov 30, 2022
ruiqiRichard
ruiqiRichard approved these changes Nov 30, 2022
View reviewed changes
Copy link
Contributor

@ruiqiRichard ruiqiRichard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go

pconrad
pconrad approved these changes Nov 30, 2022
View reviewed changes
Copy link
Contributor

@pconrad pconrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pconrad pconrad added 5 5 pts and removed STAFF: ready for review green on CI, has peer CR, no other obvious issues labels Nov 30, 2022
@pconrad pconrad merged commit fecbdf5 into main Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pconrad pconrad pconrad approved these changes

@blakerandle blakerandle blakerandle approved these changes

@RAILGUN1124 RAILGUN1124 RAILGUN1124 approved these changes

@ruiqiRichard ruiqiRichard ruiqiRichard approved these changes

@bzamora020 bzamora020 Awaiting requested review from bzamora020

@KaieChen KaieChen Awaiting requested review from KaieChen

@nathanmathew02 nathanmathew02 Awaiting requested review from nathanmathew02

@phtcon phtcon Awaiting requested review from phtcon

@archit-gpt archit-gpt Awaiting requested review from archit-gpt

@tkumar07 tkumar07 Awaiting requested review from tkumar07

@vivianross06 vivianross06 Awaiting requested review from vivianross06

Assignees
No one assigned
Labels
5 5 pts f22-7pm-4 f22-7pm-4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@FinalGale @pconrad @blakerandle @RAILGUN1124 @ruiqiRichard