Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cow sale toast when no cows are salable #49

Merged
merged 17 commits into from Nov 30, 2022
Merged

Fix cow sale toast when no cows are salable #49

merged 17 commits into from Nov 30, 2022

Conversation

ethwu
Copy link
Contributor

@ethwu ethwu commented Nov 28, 2022 •
edited by wesleykam

  • Change the toast message to reflect the fact that no cows are sold
    when a user's cow count is zero
  • Add tests for cow sale when cow count is greater than zero and when
    cow count is zero

Before:
Sell Toast Bad

After:
Sell Toast Good

Closes #48

@ethwu ethwu self-assigned this Nov 28, 2022
@pconrad pconrad added FIXME: Add Team Label Please add the label for your team, e.g. f22-4pm-3 FIXME: Peer CR Please get a peer code review labels Nov 28, 2022
@ethwu ethwu temporarily deployed to f22-7pm-3-happycows-qa November 29, 2022 00:06 Inactive
@ethwu ethwu added f22-7pm-3 f22-7pm-3 and removed FIXME: Add Team Label Please add the label for your team, e.g. f22-4pm-3 labels Nov 29, 2022
@ethwu ethwu requested review from a team November 29, 2022 00:15
@ethwu ethwu temporarily deployed to f22-7pm-3-happycows-qa November 29, 2022 00:35 Inactive
@ethwu ethwu temporarily deployed to f22-7pm-3-happycows-qa November 29, 2022 00:59 Inactive
minhbui27
minhbui27 approved these changes Nov 29, 2022
View reviewed changes
Copy link
Contributor

@minhbui27 minhbui27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ethwu ethwu removed the FIXME: Peer CR Please get a peer code review label Nov 29, 2022
@ethwu ethwu requested a review from pconrad November 29, 2022 01:44
RAILGUN1124
RAILGUN1124 approved these changes Nov 29, 2022
View reviewed changes
Copy link
Contributor

@RAILGUN1124 RAILGUN1124 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ethwu ethwu added the STAFF: ready for review green on CI, has peer CR, no other obvious issues label Nov 29, 2022
blakerandle
blakerandle approved these changes Nov 30, 2022
View reviewed changes
Copy link
Contributor

@blakerandle blakerandle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wesleykam wesleykam temporarily deployed to f22-7pm-3-happycows-qa November 30, 2022 01:24 Inactive
@pconrad pconrad temporarily deployed to f22-7pm-3-happycows November 30, 2022 17:55 Inactive
@pconrad pconrad added the Merge Candidate: Needs QA deploy Staff thinks this may be mergeable; needs to be tested on QA label Nov 30, 2022
pconrad
pconrad approved these changes Nov 30, 2022
View reviewed changes
Copy link
Contributor

@pconrad pconrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.. will test on qa before merging

@pconrad pconrad added 10 10 pts and removed Merge Candidate: Needs QA deploy Staff thinks this may be mergeable; needs to be tested on QA STAFF: ready for review green on CI, has peer CR, no other obvious issues labels Nov 30, 2022
pconrad
pconrad approved these changes Nov 30, 2022
View reviewed changes
Copy link
Contributor

@pconrad pconrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job

@pconrad pconrad merged commit 681051a into main Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pconrad pconrad pconrad approved these changes

@minhbui27 minhbui27 minhbui27 approved these changes

@blakerandle blakerandle blakerandle approved these changes

@RAILGUN1124 RAILGUN1124 RAILGUN1124 approved these changes

@bzamora020 bzamora020 Awaiting requested review from bzamora020

Assignees

@ethwu ethwu

Labels
10 10 pts f22-7pm-3 f22-7pm-3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Toast says "Cow Sold" when no cow was sold
6 participants
@ethwu @pconrad @minhbui27 @blakerandle @RAILGUN1124 @wesleykam