Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added CowDeathTable react component, storybook, fixures and tests #53

Merged
merged 12 commits into from Dec 1, 2022
Merged

Added CowDeathTable react component, storybook, fixures and tests #53

merged 12 commits into from Dec 1, 2022

Conversation

minhbui27
Copy link
Contributor

@minhbui27 minhbui27 commented Nov 29, 2022 •
edited

In this commit, I added the CowDeathTable react component (frontend) only with no endpoints (those are for other issues), a storybook component along with fixtures, and tests.

Closes #50

Storybook entry:
https://ucsb-cs156-f22.github.io/f22-7pm-happycows-docs-qa/storybook-qa/Minh-CowDeathTable/?path=/story/components-cowdeaths-cowdeathtable--five-user-commons

Below are images as shown via the storybook
image
image
image
image

@minhbui27 minhbui27 added the f22-7pm-3 f22-7pm-3 label Nov 29, 2022
@minhbui27 minhbui27 requested review from a team November 29, 2022 22:12
RAILGUN1124
RAILGUN1124 previously approved these changes Nov 29, 2022
View reviewed changes
Copy link
Contributor

@RAILGUN1124 RAILGUN1124 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve

@minhbui27 minhbui27 self-assigned this Nov 30, 2022
@minhbui27 minhbui27 added the STAFF: ready for review green on CI, has peer CR, no other obvious issues label Nov 30, 2022
blakerandle
blakerandle previously requested changes Nov 30, 2022
View reviewed changes
Copy link
Contributor

@blakerandle blakerandle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am confused by why the header for one of the columns in CowDeathTable.js is 'ZonedDateTime' rather than something like 'Created At.' I understand it is technically in the spec but it seems like a typo and would be confusing to a user.

@blakerandle blakerandle removed the STAFF: ready for review green on CI, has peer CR, no other obvious issues label Nov 30, 2022
blakerandle
blakerandle approved these changes Nov 30, 2022
View reviewed changes
Copy link
Contributor

@blakerandle blakerandle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@blakerandle blakerandle added the STAFF: ready for review green on CI, has peer CR, no other obvious issues label Nov 30, 2022
@pconrad pconrad temporarily deployed to f22-7pm-3-happycows December 1, 2022 17:11 Inactive
pconrad
pconrad approved these changes Dec 1, 2022
View reviewed changes
Copy link
Contributor

@pconrad pconrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pconrad pconrad merged commit 7437707 into main Dec 1, 2022
@pconrad pconrad added the 10 10 pts label Dec 1, 2022
@pconrad pconrad removed the STAFF: ready for review green on CI, has peer CR, no other obvious issues label Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pconrad pconrad pconrad approved these changes

@ethwu ethwu ethwu approved these changes

@blakerandle blakerandle blakerandle approved these changes

@RAILGUN1124 RAILGUN1124 RAILGUN1124 left review comments

Assignees

@minhbui27 minhbui27

Labels
10 10 pts f22-7pm-3 f22-7pm-3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add cow death table
5 participants
@minhbui27 @pconrad @ethwu @blakerandle @RAILGUN1124