Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Josiah - Article Index Placeholder #33

Merged
merged 5 commits into from Nov 9, 2022
Merged

Josiah - Article Index Placeholder #33

merged 5 commits into from Nov 9, 2022

Conversation

josiahnross
Copy link
Contributor

@josiahnross josiahnross commented Nov 4, 2022 •
edited

  • There is a page that shows up when the user goes to articles/list
  • The page file should be called ArticlesIndexPage and should be placed in frontend/src/main/pages/Articles
  • The page is linked to in App.js and can be accessed by logged-in users

Closes #4

@josiahnross josiahnross changed the base branch from main to Josiah-ArticleMenuNavBar November 9, 2022 00:37
@josiahnross
Merge remote-tracking branch 'origin/Josiah-ArticleMenuNavBar' into J…
2caacbc 
…osiah-ArticleIndexPlaceholder

Resolves Conflict
@josiahnross josiahnross changed the title Josiah article index placeholder Josiah - Article Index Placeholder Nov 9, 2022
@josiahnross josiahnross changed the base branch from Josiah-ArticleMenuNavBar to main November 9, 2022 00:42
@Gopu2001
Copy link
Contributor

Gopu2001 commented Nov 9, 2022

Did you mean a different folder for this task?

  • The page file should be called ArticlesIndexPage and should be placed in frontend/pages/articles

Should frontend/pages/articles be frontend/src/main/pages/articles?

@josiahnross josiahnross changed the base branch from main to Josiah-ArticleMenuNavBar November 9, 2022 01:50
@josiahnross josiahnross changed the base branch from Josiah-ArticleMenuNavBar to main November 9, 2022 01:50
HarvardWang
HarvardWang approved these changes Nov 9, 2022
View reviewed changes
Copy link
Contributor

@HarvardWang HarvardWang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Gopu2001
Gopu2001 requested changes Nov 9, 2022
View reviewed changes
Copy link
Contributor

@Gopu2001 Gopu2001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor change requested

frontend/src/tests/pages/Articles/ArticlesIndexPage.test.js Outdated Show resolved Hide resolved
Gopu2001
Gopu2001 approved these changes Nov 9, 2022
View reviewed changes
Copy link
Contributor

@Gopu2001 Gopu2001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@josiahnross josiahnross merged commit ea54903 into main Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gopu2001 Gopu2001 Gopu2001 approved these changes

@HarvardWang HarvardWang HarvardWang approved these changes

Assignees

@josiahnross josiahnross

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Placeholder for Article Index Page
3 participants
@josiahnross @Gopu2001 @HarvardWang