Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Josiah - Article Table on Article Index Page #43

Merged
merged 9 commits into from Nov 11, 2022
Merged

Josiah - Article Table on Article Index Page #43

merged 9 commits into from Nov 11, 2022

Conversation

josiahnross
Copy link
Contributor

@josiahnross josiahnross commented Nov 9, 2022 •
edited

Closes #7

  • Add Articles Table to the Articles Index Page
  • When the user goes to the articles index page they see a table of articles with all of the articles from the database with the correct field headers
  • The Articles Index Page is covered by testing that makes sure that the table displays for normal and admin users, that it works both with test data, and that it displays an empty table when it's not able to connect to the backend.

@josiahnross josiahnross changed the base branch from Josiah-StorybookArticleTable to main November 9, 2022 21:07
@josiahnross josiahnross self-assigned this Nov 9, 2022
@josiahnross josiahnross changed the base branch from main to 8-add-helprequest-component-to-storybook-along-with-fixtures November 10, 2022 23:33
@josiahnross josiahnross changed the base branch from 8-add-helprequest-component-to-storybook-along-with-fixtures to main November 10, 2022 23:34
@josiahnross josiahnross changed the base branch from main to Colter-MenuItemNavBar November 10, 2022 23:34
@josiahnross josiahnross changed the base branch from Colter-MenuItemNavBar to main November 10, 2022 23:34
HarvardWang
HarvardWang approved these changes Nov 11, 2022
View reviewed changes
Copy link
Contributor

@HarvardWang HarvardWang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@josiahnross josiahnross merged commit 882a759 into main Nov 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HarvardWang HarvardWang HarvardWang approved these changes

Assignees

@josiahnross josiahnross

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace ArticleTable placeholder page with one that includes Article Table
2 participants
@josiahnross @HarvardWang