Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8 add helprequest component to storybook along with fixtures #47

Merged

Conversation

HarvardWang
Copy link
Contributor

Closes #8

  • There is a HelpRequestsTable.js file in frontend/main/components/HelpRequests.
  • There is a helpRequestsFixtures.js file in frontend/src/fixtures with an example oneHelpRequest and an example threeHelpRequests.
  • There is a HelpRequestsTable.stories.js file in frontend/src/stories/components/Articles.
  • In the storybook there is an HelpRequests Folder with a HelpRequestsTable inside with Empty , Three Articles , and Three Help Requests as Admin.
  • When Empty is clicked there is a table with all of the headers of an article but with no items in the table.
  • When Three Help Requests is clicked there is a table with all of the headers of an article with three items in the table with the correct values corresponding to the values in the articlesFixtures.js file.
  • There is a corresponding HelpRequestsTable.test.js that tests HelpRequests.js.

@HarvardWang HarvardWang linked an issue Nov 10, 2022 that may be closed by this pull request
7 tasks
@HarvardWang HarvardWang self-assigned this Nov 10, 2022
Copy link
Contributor

@josiahnross josiahnross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@HarvardWang HarvardWang merged commit c1b9306 into main Nov 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add HelpRequest component to Storybook (along with fixtures)
2 participants