Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New and Improved Farmer Greeting Messages #30

Closed
wants to merge 4 commits into from

Conversation

amgadhawari
Copy link
Contributor

Overview

In this PR, I improved the greeting message in Home and Play Page that can be seen on Happy Cow Project.

Screenshots (Optional)

Screenshot 2023-11-20 at 1 26 10 PM

Feedback Request (Optional)

  • Please let me know what improvements I can make on this code to make the website look a lot cooler.

Future Possibilities (Optional)

I want to make the title/ greeting message move around on the screen

Validation (Optional)

  1. Download this branch./ git pull this branch into your existing project.
  2. Run the project.
  3. Go to this page.
  4. Test this function.

Tests

  • Backend Unit tests (mvn test) pass
  • Backend Test coverage (mvn test jacoco:report) 100%
  • Backend Mutation tests (mvn test pitest:mutationCoverage) 100%
  • Frontend Unit tests (npm test) pass
  • Frontend Test coverage (npm run coverage) 100%
  • Frontend Mutation tests (npx stryker run) 100%
  • Frontend Linting (npx eslint --fix src)

Linked Issues

Closes #13

@amgadhawari amgadhawari added the enhancement New feature or request label Nov 20, 2023
@amgadhawari amgadhawari self-assigned this Nov 20, 2023
@pconrad pconrad added the FIXME-see code review Please review the comments in the code review and address them; then remove this label label Nov 21, 2023
Copy link
Contributor

@pconrad pconrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks ok, but I'm not so sure about the design choices:

  • Current design has low contrast between background and text, which makes it hard to read. Maybe mockup some differerent designs and get some feedback from the team on them.
  • The named individual is a farmer, not a cow, so make sure the greeting recognizes this. I think the intent of the issue was to work with the presentation of Howdy Farmer {firstName} rather than change the text.

@pconrad
Copy link
Contributor

pconrad commented Dec 5, 2023

Abandoned by team, so closing.

@pconrad pconrad closed this Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request FIXME-merge conflicts FIXME-see code review Please review the comments in the code review and address them; then remove this label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FEATURE: Farmer greetings message UI improvement
2 participants