Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pc - try to resolve flaky test #64

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

pc - try to resolve flaky test #64

wants to merge 2 commits into from

Conversation

pconrad
Copy link
Contributor

@pconrad pconrad commented Dec 6, 2023

In this PR, we try to resolve a flaky test by:

  • separating it out into its own file, so that it has its only private Argument Captor, to try to avoid interactions with other tests
  • make the test flexible for which of the calls to save has the error in it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jingpeng7527 jingpeng7527 Awaiting requested review from jingpeng7527 jingpeng7527 is a code owner

@andrewpengucsb andrewpengucsb Awaiting requested review from andrewpengucsb andrewpengucsb is a code owner

@GlassBricks GlassBricks Awaiting requested review from GlassBricks GlassBricks is a code owner

@sangitakunapuli sangitakunapuli Awaiting requested review from sangitakunapuli sangitakunapuli is a code owner

@LeonFeng0325 LeonFeng0325 Awaiting requested review from LeonFeng0325 LeonFeng0325 is a code owner

@briggsrrr briggsrrr Awaiting requested review from briggsrrr briggsrrr is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pconrad @phtcon