Staff channel list #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The pattern is *~
It still uses fake data, and there are no tests yet. Next steps are to build backend routes, the code to get data to the front end and then tests.
Codecov Report
@@ Coverage Diff @@
## main #16 +/- ##
==============================================
- Coverage 100.00% 81.14% -18.86%
- Complexity 149 162 +13
==============================================
Files 32 38 +6
Lines 368 488 +120
Branches 14 17 +3
==============================================
+ Hits 368 396 +28
- Misses 0 92 +92
Continue to review full report at Codecov.
|
* Added front end component for page and table for channels * Added backend document, repository, and controller for channels
Replaced Objects.equals with EqualsBuilder for easier testing Replaced getter/setter tests with JavaBeanTester for less code to maintain
pconrad
force-pushed
the
staff-channelList
branch
from
0f417b8
to
d42472a
Compare
scottpchow23
previously approved these changes
Nov 24, 2020
src/test/java/edu/ucsb/mapache/documents/ChannelTopicTests.java
Outdated
Show resolved
Hide resolved
…pache-search into staff-channelList
pconrad
force-pushed
the
staff-channelList
branch
from
d42472a
to
d1f0341
Compare
scottpchow23
approved these changes
Nov 24, 2020
|
Merged in spite of the fact that codecov showed a failure: we are aware of the tech debt in both front and back end tests and will pay it down over the next few weeks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR we add the ability to list channels.
This is a scaffold on which the F20 teams can build.
Note that this was merged with incomplete test coverage; that is technical debt that we need to pay down. That might be a combination of staff effort and stories for the F20 teams. If done by F20 teams, we will award points towards their 100 point total.
Resolves #11.