Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Placeholder Index Page for Menu Item #49

Merged
merged 4 commits into from May 19, 2022

Conversation

ryang1337
Copy link
Contributor

Added a placeholder for the UCSBDiningCommonsMenuItemIndex Page. Updated the routing in AppNavbar.js to redirect to the placeholder page. Added tests to make sure the placeholder page renders.

100% coverage with npm run coverage
Mutation score of 100 with npx stryker run

Closes #24

@ryang1337 ryang1337 self-assigned this May 16, 2022
@codecov
Copy link

codecov bot commented May 16, 2022

Codecov Report

Merging #49 (b2500d7) into main (ffd23a2) will not change coverage.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##                main       #49   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
  Complexity        54        54           
===========================================
  Files             39        40    +1     
  Lines            270       271    +1     
===========================================
+ Hits             270       271    +1     
Impacted Files Coverage Δ
...monsMenuItem/UCSBDiningCommonsMenuItemIndexPage.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ffd23a2...b2500d7. Read the comment docs.

Copy link
Contributor

@aaron-sgy aaron-sgy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@yuheho7749 yuheho7749 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@TokyoExpress TokyoExpress left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. all tests pass

@aaron-sgy aaron-sgy merged commit dafec14 into main May 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Placeholder for Menu Item Index Page
4 participants