-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added school edit pages, utils, tests, stories #36
Conversation
nevermind, tested the edit button and it seems to not be linked. please don't review for now! |
ok, seems to be fixed, can review now! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix the commented out code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good.. but when I tried this on the dokku deployment, I was unable to create a school. Therefore I was unable to test editing a school, which seems to be the main thing in this PR.
I wonder if your dokku deployment is out of date?
Or if create is in a different PR that needs to come before this one for testing purposes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, sorry yes that is the case! Since this requires a school to have been created already, for testing purposes this PR must come after EPIC Issue #4 F1.1. Another option that I tried and confirmed was to test on localhost, creating a school using Swagger and attempting to use the edit button there. It may also be possible to edit the initial database for Dokku, however for simplicity's sake, should I leave this PR as it is with just localhost screenshots, and create a new PR later for the dev deployment once EPIC Issue #4 F1.1 is done? |
Ok, I updated the PR description so that anyone can go to Swagger first and create a school entry. That way there is an entry present to test "edit button" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make sure that the backend api in your branch matches this:
And make sure that you've tested delete. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am reluctantly approving this even though it has a broken Delete button. We'll just have to hope that the next PR fixes that.
Worked on Issue #33, which I split from EPIC issue #4, which sets up the frontend for School CRUD
https://organic-30912hyl.dokku-11.cs.ucsb.edu/
Since school Create has not been implemented yet, in order to test this please first manually create a school entry with https://organic-30912hyl.dokku-11.cs.ucsb.edu/swagger-ui/index.html#/
Closes #33