Added tooltip UX to School variables(abbrev, desc, regex) #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
30912hyl
requested review from
pconrad,
Aasish-Virjala,
andrewpengucsb,
AnikaArora,
sangitakunapuli,
sanilkatula and
whuang602
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically what the title says. I also removed termError from SchoolForm, Table, and fixtures, as no one seems to know what it is for. In order to test this code, create/edit button must be functional. As create has not been merged to main as of right now, I have been testing it by running the code on storybook. Once F1.1 of EPIC Issue #4 is merged, I will create a new PR with a dev development on Dokku. As of now, please use storybook and hover over the corresponding values(abbrev, description, regex) to test if tooltip works.
Step 1: Navigate to School and select either SchoolForm or SchoolTable in Storybook
Step 2: Hover over the respective variables(NOTE: it is intended that name has no tooltip as it is self-explanatory, please let me know if you think I should make one)
Closes #49