Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rd - create commons storybook page #34

Merged
merged 1 commit into from
Mar 9, 2022
Merged

Conversation

rsdharmaji
Copy link
Contributor

Overview

adds a storybook entry for the create commons page (was missing from starter code).

Issues Addressed

closes #19

Details

none not stated above.

@codecov
Copy link

codecov bot commented Mar 7, 2022

Codecov Report

Merging #34 (7488a51) into main (7431e39) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##               main      #34   +/-   ##
=========================================
  Coverage     67.40%   67.40%           
  Complexity       42       42           
=========================================
  Files            47       47           
  Lines           359      359           
  Branches          9        9           
=========================================
  Hits            242      242           
  Misses          116      116           
  Partials          1        1           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7431e39...7488a51. Read the comment docs.

@rsdharmaji rsdharmaji requested a review from btk5h March 7, 2022 21:23
@rsdharmaji rsdharmaji added the Attn-peer-CR At least one team member should do a code review before the staff label Mar 9, 2022
@Sytarno Sytarno self-requested a review March 9, 2022 02:53
Copy link
Contributor

@Sytarno Sytarno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran storybook locally. The page shows up as AdminCreateCommonsPage, so looks good from my end. Didn't know the page was called that though. Kind of a long name.

@Sytarno Sytarno removed the Attn-peer-CR At least one team member should do a code review before the staff label Mar 9, 2022
@rsdharmaji rsdharmaji requested a review from kheff16 March 9, 2022 04:02
@btk5h btk5h merged commit 57d8705 into main Mar 9, 2022
@btk5h btk5h deleted the rd-commons-create-storybook branch March 9, 2022 22:43
@btk5h btk5h added the 5 label Mar 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6pm-4: add stories and testing for Commons Create page
4 participants