-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
jk- create listPage #40
Conversation
Codecov Report
@@ Coverage Diff @@
## main #40 +/- ##
============================================
+ Coverage 77.80% 78.78% +0.98%
Complexity 59 59
============================================
Files 48 51 +3
Lines 374 396 +22
Branches 10 10
============================================
+ Hits 291 312 +21
- Misses 83 84 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems there are some code coverage problems ... they are pointed out by the codecov comments on the PR.
See if you can address these.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reverted date conversion and button columns.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
b65239f
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now with 📕.
Overview
CommonsList
. Add its storybook entry. Modify the router and navigation bar to support the new page.CommonsTable
. Add its storybook entry.commonsUtil.js
.Details
#12, #35, #36, #48