Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Market Cow Price and Number of Cows #42

Merged
merged 10 commits into from
Mar 12, 2022
Merged

Market Cow Price and Number of Cows #42

merged 10 commits into from
Mar 12, 2022

Conversation

gama-A
Copy link
Contributor

@gama-A gama-A commented Mar 9, 2022

Overview

This PR cowMarket price is correctly displayed on the playPage. numOfCows variable has been added to the userCommons entity and is correctly displayed on the playPage.

Issues Addressed

#14 Part of this issue is addresses the following PR will be to properly implement the buy and sell functionality to properly update number of cows for a user.

@gama-A gama-A requested a review from sethvanb March 9, 2022 02:42
@codecov
Copy link

codecov bot commented Mar 9, 2022

Codecov Report

Merging #42 (1ad5707) into main (b771c68) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##               main      #42   +/-   ##
=========================================
  Coverage     77.80%   77.80%           
  Complexity       59       59           
=========================================
  Files            48       48           
  Lines           374      374           
  Branches         10       10           
=========================================
  Hits            291      291           
  Misses           83       83           
Impacted Files Coverage Δ
frontend/src/main/pages/PlayPage.js 100.00% <ø> (ø)
frontend/src/main/components/Commons/ManageCows.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b771c68...1ad5707. Read the comment docs.

@gama-A gama-A requested a review from Lin2 March 9, 2022 02:43
@gama-A gama-A requested review from btk5h and ryanmosalem March 9, 2022 02:49
@gama-A
Copy link
Contributor Author

gama-A commented Mar 9, 2022

@bzamora020

ryanmosalem
ryanmosalem previously approved these changes Mar 9, 2022
Copy link
Contributor

@ryanmosalem ryanmosalem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

btk5h
btk5h previously approved these changes Mar 9, 2022
Copy link
Contributor

@btk5h btk5h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the .DS_Store file from your PR.

Copy link
Contributor

@btk5h btk5h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the .DS_Store file from your PR.

@gama-A
Copy link
Contributor Author

gama-A commented Mar 9, 2022

Please remove the .DS_Store file from your PR.

I have removed the file and pushed my changes, will ping you on slack when all checks are finished again.

@gama-A gama-A removed the request for review from Lin2 March 9, 2022 22:57
@pconrad pconrad added the Attn-CI/CD-failures At least one of the CI/CD scripts is failing label Mar 11, 2022
@andrewhlu andrewhlu removed the Attn-CI/CD-failures At least one of the CI/CD scripts is failing label Mar 11, 2022
Copy link
Contributor

@pconrad pconrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM... as long as it works on Heroku. I'll try deploying it

@pconrad pconrad temporarily deployed to team04-w22-6pm-3 March 11, 2022 19:03 Inactive
@johnsonlin2001 johnsonlin2001 temporarily deployed to team04-w22-6pm-3 March 11, 2022 19:31 Inactive
@gama-A gama-A temporarily deployed to team04-w22-6pm-3 March 11, 2022 19:55 Inactive
@bzamora020 bzamora020 temporarily deployed to team04-w22-6pm-3 March 11, 2022 20:27 Inactive
@bzamora020
Copy link

When ran on Heroku, the play page does not work as expected.

image

@bzamora020 bzamora020 temporarily deployed to team04-w22-6pm-3-qa March 11, 2022 20:37 Inactive
@eambriz27 eambriz27 temporarily deployed to team04-w22-6pm-3 March 11, 2022 20:38 Inactive
@johnsonlin2001 johnsonlin2001 temporarily deployed to team04-w22-6pm-3 March 11, 2022 21:11 Inactive
@johnsonlin2001 johnsonlin2001 temporarily deployed to team04-w22-6pm-3 March 11, 2022 21:40 Inactive
@johnsonlin2001
Copy link
Contributor

johnsonlin2001 commented Mar 11, 2022

When ran on Heroku, the play page does not work as expected.

image

@bzamora020
I rebuilt the tables on heroku and I believe the playpage should show up now.
Screen Shot 2022-03-11 at 1 42 52 PM

@andrewhlu andrewhlu temporarily deployed to team04-w22-6pm-3-qa March 11, 2022 22:19 Inactive
@johnsonlin2001 johnsonlin2001 temporarily deployed to team04-w22-6pm-3 March 11, 2022 22:32 Inactive
@andrewhlu
Copy link
Contributor

Hi all, I'm trying to deploy this branch to your 6pm-4-qa deployment so I can test out the play page, but I can't log in to your app due to a redirect URI mismatch. Could you all fix that?

@johnsonlin2001 johnsonlin2001 temporarily deployed to team04-w22-6pm-3-qa March 11, 2022 22:47 Inactive
@johnsonlin2001 johnsonlin2001 temporarily deployed to team04-w22-6pm-3-qa March 11, 2022 23:05 Inactive
@johnsonlin2001
Copy link
Contributor

johnsonlin2001 commented Mar 11, 2022

@andrewhlu
I believe 6pm-3-qa should allow logins now. The playpage also shows up on the qa deployment.

@pconrad pconrad temporarily deployed to team04-w22-6pm-3-qa March 12, 2022 01:47 Inactive
@pconrad pconrad temporarily deployed to team04-w22-6pm-3-qa March 12, 2022 01:50 Inactive
@pconrad pconrad added the Attn-respond-to-CR Please address changes requested in code review label Mar 12, 2022
@pconrad pconrad temporarily deployed to team04-w22-6pm-3-qa March 12, 2022 04:01 Inactive
@pconrad pconrad added 10 and removed Attn-respond-to-CR Please address changes requested in code review labels Mar 12, 2022
@pconrad pconrad merged commit 4b2e41b into main Mar 12, 2022
@andrewhlu andrewhlu deleted the 6pm-3-ManageCows branch March 12, 2022 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants