-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Market Cow Price and Number of Cows #42
Conversation
Codecov Report
@@ Coverage Diff @@
## main #42 +/- ##
=========================================
Coverage 77.80% 77.80%
Complexity 59 59
=========================================
Files 48 48
Lines 374 374
Branches 10 10
=========================================
Hits 291 291
Misses 83 83
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove the .DS_Store
file from your PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove the .DS_Store file from your PR.
I have removed the file and pushed my changes, will ping you on slack when all checks are finished again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM... as long as it works on Heroku. I'll try deploying it
@bzamora020 |
Hi all, I'm trying to deploy this branch to your 6pm-4-qa deployment so I can test out the play page, but I can't log in to your app due to a redirect URI mismatch. Could you all fix that? |
@andrewhlu |
Overview
This PR cowMarket price is correctly displayed on the playPage. numOfCows variable has been added to the userCommons entity and is correctly displayed on the playPage.
Issues Addressed
#14 Part of this issue is addresses the following PR will be to properly implement the buy and sell functionality to properly update number of cows for a user.