-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implement "delete a commons" functionality in commonsController.java
#44
Conversation
Codecov Report
@@ Coverage Diff @@
## main #44 +/- ##
============================================
+ Coverage 78.78% 79.30% +0.51%
- Complexity 59 61 +2
============================================
Files 51 51
Lines 396 401 +5
Branches 10 10
============================================
+ Hits 312 318 +6
+ Misses 84 83 -1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use proper HTTP statuses when the server replies later.
src/test/java/edu/ucsb/cs156/happiercows/controllers/CommonsControllerTests.java
Show resolved
Hide resolved
src/main/java/edu/ucsb/cs156/happiercows/controllers/CommonsController.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ca181bb
to
7505020
Compare
Needs rebase or merge with main but otherwise lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we broke anything merging.
#52 affects this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This patch doesn't work, unfortunately.
Overview
the delete method is added to the commons controller
Issues Addressed
closes #32
Details
delete method supports an id for deletion, and throws an
EntityNotFoundException
if deleting nonexistent commons.ADMIN
authentication is required to use the delete method.here is an "after" image: