Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dc - Partial implementation of the edit and delete column with two broken tests. #53

Closed
wants to merge 13 commits into from

Conversation

jacksoncooper
Copy link
Contributor

@jacksoncooper jacksoncooper commented Mar 12, 2022

This branch can be demoed, but not merged. Our team ran into two core issues.

  • When mocking, the toast and navigation elements do not appear in the DOM.
  • A race condition (?) where sometimes the edit page renders before the selected Commons is retrieved from the backend, and so react-query uses the cached date in the form. useBackend can't communicate with the client code.
demo.mov

The delete buttons are nonfunctional.

@codecov
Copy link

codecov bot commented Mar 12, 2022

Codecov Report

Merging #53 (59b9b15) into main (b4f5ce2) will decrease coverage by 12.87%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##               main      #53       +/-   ##
=============================================
- Coverage     81.09%   68.21%   -12.88%     
  Complexity       75       75               
=============================================
  Files            52       21       -31     
  Lines           439      258      -181     
  Branches         12       12               
=============================================
- Hits            356      176      -180     
+ Misses           83       82        -1     
Impacted Files Coverage Δ
...ontend/src/main/components/Commons/CommonsTable.js
...d/src/main/components/Commons/CreateCommonsForm.js
frontend/src/main/pages/AdminCreateCommonsPage.js
frontend/src/main/utils/commonsUtils.js
frontend/src/main/utils/users.js
frontend/src/main/utils/systemInfo.js
frontend/src/main/utils/arrayUtils.js
frontend/src/main/components/Commons/Profits.js
...tend/src/main/components/Nav/AppNavbarLocalhost.js
frontend/src/main/pages/LoginPage.js
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b4f5ce2...59b9b15. Read the comment docs.

@jacksoncooper jacksoncooper changed the title dc - Partial implementation of page to edit commons with broken tests. dc - Partial implementation of the edit and delete column with two broken tests. Mar 13, 2022
@DannyCoco DannyCoco temporarily deployed to team04-w22-6pm-4-qa March 14, 2022 23:23 Inactive
@DannyCoco DannyCoco temporarily deployed to team04-w22-6pm-4-qa March 15, 2022 00:54 Inactive
@DannyCoco DannyCoco temporarily deployed to team04-w22-6pm-4-qa March 15, 2022 01:07 Inactive
@andrewhlu
Copy link
Contributor

Hi! If your team does not intend on merging this PR, can you mark it as a draft? Thanks!

@jacksoncooper jacksoncooper marked this pull request as draft March 24, 2022 08:47
@jacksoncooper
Copy link
Contributor Author

End of quarter, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants