-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
w22-6pm-3 Adding images and background picture to Play Page UI #54
Conversation
Codecov Report
@@ Coverage Diff @@
## main #54 +/- ##
=========================================
Coverage 81.09% 81.09%
Complexity 75 75
=========================================
Files 52 52
Lines 439 439
Branches 12 12
=========================================
Hits 356 356
Misses 83 83
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thank you for adding the images
Overview
In this PR, we added images and a background picture for the Play Page from the assets section of the repository.
Issues Addressed
This issue addresses 2 parts of #16.
These tasks specifically:
Images appear after insertion to FarmStats.js, ManageCows.js, and wherever is appropriate (run frontend to see where images are lacking).
Images are free for public use or educational use.
Details
![image](https://user-images.githubusercontent.com/69827289/158004581-b84b9e95-a80c-4b27-aa31-4aa6e347e5bb.png)
Above is after adding pictures and background to Play Page.Note that the 'not quite visible' part of the commit message was before testing with heroku. When branch is deployed to Heroku these images are visible and UI works as intended.