Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

w22-6pm-3 Adding images and background picture to Play Page UI #54

Merged
merged 4 commits into from
Mar 12, 2022

Conversation

eambriz27
Copy link
Contributor

Overview

In this PR, we added images and a background picture for the Play Page from the assets section of the repository.

Issues Addressed

This issue addresses 2 parts of #16.
These tasks specifically:

  • Images appear after insertion to FarmStats.js, ManageCows.js, and wherever is appropriate (run frontend to see where images are lacking).

  • Images are free for public use or educational use.

Details

image

Above is after adding pictures and background to Play Page.

Note that the 'not quite visible' part of the commit message was before testing with heroku. When branch is deployed to Heroku these images are visible and UI works as intended.

@codecov
Copy link

codecov bot commented Mar 12, 2022

Codecov Report

Merging #54 (e7c901a) into main (0b7a9ba) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##               main      #54   +/-   ##
=========================================
  Coverage     81.09%   81.09%           
  Complexity       75       75           
=========================================
  Files            52       52           
  Lines           439      439           
  Branches         12       12           
=========================================
  Hits            356      356           
  Misses           83       83           
Impacted Files Coverage Δ
frontend/src/main/components/Commons/FarmStats.js 100.00% <ø> (ø)
frontend/src/main/components/Commons/ManageCows.js 100.00% <ø> (ø)
frontend/src/main/pages/PlayPage.js 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b7a9ba...e7c901a. Read the comment docs.

@eambriz27 eambriz27 temporarily deployed to team04-w22-6pm-3-qa March 12, 2022 21:11 Inactive
Copy link
Contributor

@pconrad pconrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pconrad pconrad added Attn-peer-CR At least one team member should do a code review before the staff Merge-Candidate Staff thinks this is close to being mergeable; just waiting on either CI/CD or testing on Heroku labels Mar 12, 2022
Copy link
Contributor

@gama-A gama-A left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thank you for adding the images

@johnsonlin2001 johnsonlin2001 temporarily deployed to team04-w22-6pm-3 March 12, 2022 22:04 Inactive
@pconrad pconrad merged commit 18945b8 into main Mar 12, 2022
@pconrad pconrad added 10 and removed Attn-peer-CR At least one team member should do a code review before the staff Merge-Candidate Staff thinks this is close to being mergeable; just waiting on either CI/CD or testing on Heroku labels Mar 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants