Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

W22-6pm-3 Success toast shows correct information when creating a new commons #56

Merged
merged 4 commits into from
Mar 12, 2022
Merged

W22-6pm-3 Success toast shows correct information when creating a new commons #56

merged 4 commits into from
Mar 12, 2022

Conversation

johnsonlin2001
Copy link
Contributor

@johnsonlin2001 johnsonlin2001 commented Mar 12, 2022 •
edited by gama-A

Overview

Modified the create commons toast on the AdminCreateCommonsPage to retrieve the correct variable "startingDate" from commons. Also reformatted the toast to include a semicolon and space so that the message is more legible.

Before:
Screen Shot 2022-03-12 at 1 32 44 PM

After
Image from iOS

Issues Addressed

#55 solved

@codecov
Copy link

codecov bot commented Mar 12, 2022 •
edited

Codecov Report

Merging #56 (65c584e) into main (18945b8) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##               main      #56   +/-   ##
=========================================
  Coverage     81.09%   81.09%           
  Complexity       75       75           
=========================================
  Files            52       52           
  Lines           439      439           
  Branches         12       12           
=========================================
  Hits            356      356           
  Misses           83       83
Impacted Files Coverage Δ
frontend/src/main/pages/AdminCreateCommonsPage.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 18945b8...65c584e. Read the comment docs.

@johnsonlin2001
Merge pull request #57 from ucsb-cs156-w22/main
52c2e38 
merging main with 6pm-3-CorrectDate
@johnsonlin2001 johnsonlin2001 temporarily deployed to team04-w22-6pm-3 March 12, 2022 21:56 Inactive
eambriz27
eambriz27 approved these changes Mar 12, 2022
View reviewed changes
Copy link
Contributor

@eambriz27 eambriz27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice formatting, LGTM!

@eambriz27 eambriz27 requested a review from pconrad March 12, 2022 22:07
pconrad
pconrad approved these changes Mar 12, 2022
View reviewed changes
Copy link
Contributor

@pconrad pconrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pconrad pconrad added 10 Merge-Candidate Staff thinks this is close to being mergeable; just waiting on either CI/CD or testing on Heroku labels Mar 12, 2022
@pconrad pconrad merged commit b4f5ce2 into main Mar 12, 2022
@pconrad pconrad removed the Merge-Candidate Staff thinks this is close to being mergeable; just waiting on either CI/CD or testing on Heroku label Mar 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pconrad pconrad pconrad approved these changes

@eambriz27 eambriz27 eambriz27 approved these changes

Assignees
No one assigned
Labels
10 w22-6pm-3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@johnsonlin2001 @pconrad @eambriz27 @gama-A