Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

6pm-3: Buy and Sell working through Swagger/Backend #59

Closed
wants to merge 3 commits into from

Conversation

gama-A
Copy link
Contributor

@gama-A gama-A commented Mar 13, 2022

Overview

This PR adds the functionality of buy and sell to the backend and can be used through Swagger. The proper equations for buy and sell (using the weighted scale when selling) are not implemented at the moment through this PR. (The backend tests for buy and sell are not implemented yet in this PR explaining the drop in codecov at the moment)

Issues Addressed

#14 is partially addressed in this PR

Details

Screen Shot 2022-03-13 at 1 57 26 PM

Screen Shot 2022-03-13 at 1 57 45 PM

The above two images showcase the buy function

Screen Shot 2022-03-13 at 1 58 33 PM

Screen Shot 2022-03-13 at 1 58 49 PM

The above two images showcase the sell function

@codecov
Copy link

codecov bot commented Mar 13, 2022

Codecov Report

Merging #59 (65caba6) into main (b4f5ce2) will increase coverage by 18.35%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##               main      #59       +/-   ##
=============================================
+ Coverage     81.09%   99.44%   +18.35%     
=============================================
  Files            52       31       -21     
  Lines           439      181      -258     
  Branches         12        0       -12     
=============================================
- Hits            356      180      -176     
+ Misses           83        1       -82     
Impacted Files Coverage Δ
...156/happiercows/controllers/CommonsController.java
...156/happiercows/controllers/ProfitsController.java
...happiercows/controllers/UserCommonsController.java
...cs156/happiercows/services/CurrentUserService.java
...56/happiercows/services/SystemInfoServiceImpl.java
...56/happiercows/controllers/UserInfoController.java
...56/happiercows/errors/EntityNotFoundException.java
.../cs156/happiercows/controllers/CSRFController.java
.../happiercows/controllers/SystemInfoController.java
...ucsb/cs156/happiercows/HappierCowsApplication.java
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b4f5ce2...65caba6. Read the comment docs.

@gama-A gama-A changed the title 6pm-3: Buy and Sell working through Swagger (No tests yet) 6pm-3: Buy and Sell working through Swagger/Backend Mar 13, 2022
@eambriz27 eambriz27 temporarily deployed to team04-w22-6pm-3 March 13, 2022 22:31 Inactive
@eambriz27 eambriz27 temporarily deployed to team04-w22-6pm-3 March 13, 2022 22:39 Inactive
@eambriz27 eambriz27 temporarily deployed to team04-w22-6pm-3 March 13, 2022 22:41 Inactive
@sophiajmoore
Copy link
Contributor

Made a different pull request which addresses the same changes on a different branch

@sophiajmoore sophiajmoore deleted the 6pm-3-BackendCode branch March 14, 2022 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants