6pm-3: Buy and Sell working through Swagger/Backend #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e sense to save a usercommons to a nonexistent commons
…l as 2 for non-existing sell and buy
…ing for when only commons doesn't exist
… to match with the way they are called from playpage
…added in onBuy, onSell
Codecov Report
@@ Coverage Diff @@
## main #60 +/- ##
=============================================
- Coverage 81.09% 69.96% -11.14%
- Complexity 75 79 +4
=============================================
Files 52 21 -31
Lines 439 273 -166
Branches 12 12
=============================================
- Hits 356 191 -165
+ Misses 83 82 -1 Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR adds the functionality of buy and sell to the backend and can be used through Swagger. The proper equations for buy and sell (using the weighted scale when selling) are not implemented at the moment through this PR.
All that has been changed is that the backend was pulled from PR #58 , and the frontend code is from main.
Issues Addressed
#14 is partially addressed in this PR
Details
The two images below show that "Buy" is working.
The images below show that "Sell" is working.
