Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FEATURE: More descriptive error message on personal schedule #35

Closed
wants to merge 15 commits into from
Closed

FEATURE: More descriptive error message on personal schedule #35

wants to merge 15 commits into from

Conversation

Torry051
Copy link
Contributor

@Torry051 Torry051 commented Mar 6, 2024 •
edited by samanthwest

Add a more descriptive error message. When user want to add a course without any schedule, it will report error.

For bonus part, I add a button to create a new personal schedule. This button will only show up, when the page report error.

Error

Dokku dev:
https://project-samanthwest.dokku-08.cs.ucsb.edu

Closes #5

@tallyhawley
Copy link
Contributor

tallyhawley commented Mar 7, 2024 •
edited

Please add the issue that this PR closes to the description, as well as a dokku link if you can :)

@tallyhawley tallyhawley added 10 points This issue is worth 10 points FIXME - Peer CR labels Mar 7, 2024
samanthwest
samanthwest previously approved these changes Mar 7, 2024
View reviewed changes
Copy link
Contributor

@samanthwest samanthwest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

tallyhawley
tallyhawley requested changes Mar 7, 2024
View reviewed changes
Copy link
Contributor

@tallyhawley tallyhawley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not expected behavior:

image

It should still return the original error message if there is a personal schedule present.

@Torry051
Copy link
Contributor Author

Torry051 commented Mar 7, 2024 •
edited

image

The original error message will show when there is personal schedule.

megumi-ondo
megumi-ondo previously approved these changes Mar 7, 2024
View reviewed changes
Copy link
Contributor

@megumi-ondo megumi-ondo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tallyhawley
Copy link
Contributor

The original error message will show when there is personal schedule.

Has this been deployed to dokku? Testing on dokku right now, I still see the old behavior:
image

@Torry051
Copy link
Contributor Author

Torry051 commented Mar 7, 2024

The original error message will show when there is personal schedule.

Has this been deployed to dokku? Testing on dokku right now, I still see the old behavior: image

https://proj-courses-torry051-dev.dokku-08.cs.ucsb.edu

Sorry, I forgot to update the deployment. Here is the new deployment.

@tallyhawley
Copy link
Contributor

tallyhawley commented Mar 7, 2024 •
edited

Running into another issue: probably the same as ucsb-cs156-w24/proj-courses-w24-5pm-2#20

image

Got around that issue and got this (400 errors on dokku do not have a message, but they do on localhost):
image

samanthwest
samanthwest previously approved these changes Mar 8, 2024
View reviewed changes
Copy link
Contributor

@samanthwest samanthwest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tallyhawley
Copy link
Contributor

Has your dokku been redeployed? I'm still seeing the same behavior as before.

@Torry051
Copy link
Contributor Author

Torry051 commented Mar 8, 2024

Has your dokku been redeployed? I'm still seeing the same behavior as before.

It should work now
https://proj-courses-torry051-dev.dokku-08.cs.ucsb.edu

@tallyhawley
Copy link
Contributor

Still getting the same behavior.

Screen.Recording.2024-03-11.at.2.15.57.AM.mov

@Torry051 Torry051 closed this Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tallyhawley tallyhawley tallyhawley requested changes

@samanthwest samanthwest samanthwest left review comments

@megumi-ondo megumi-ondo megumi-ondo left review comments

@scottpchow23 scottpchow23 Awaiting requested review from scottpchow23 scottpchow23 is a code owner

@andrewpengucsb andrewpengucsb Awaiting requested review from andrewpengucsb andrewpengucsb is a code owner

@AnikaArora AnikaArora Awaiting requested review from AnikaArora AnikaArora is a code owner

@sangitakunapuli sangitakunapuli Awaiting requested review from sangitakunapuli sangitakunapuli is a code owner

@Aasish-Virjala Aasish-Virjala Awaiting requested review from Aasish-Virjala Aasish-Virjala is a code owner

@whuang602 whuang602 Awaiting requested review from whuang602 whuang602 is a code owner

Assignees
No one assigned
Labels
10 points This issue is worth 10 points FIXME - Changes Requested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FEATURE: More descriptive error message on personal schedule
4 participants
@Torry051 @tallyhawley @samanthwest @megumi-ondo