Driver Availability: Add controller GET all endpoint for driver availability and tests #56
+53
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JosephLiCodes
requested review from
scottpchow23,
andrewpengucsb,
AnikaArora,
sangitakunapuli,
tallyhawley,
Aasish-Virjala and
whuang602
as code owners
wzqd
changed the title
JosephLiCodes
force-pushed
the
driverAvailabilityControllerpt3
branch
from
3cca951
to
943ffb9
Compare
andrewpengucsb
requested changes
Mar 15, 2024
| @@ -102,5 +101,15 @@ public Object deleteDriverAvailability( | |||
|
|
|||
| return genericMessage("DriverAvailability with id %s deleted".formatted(id)); | |||
| } | |||
|
|
|||
| @Operation(summary = "List all availabilities of current user") | |||
| @PreAuthorize("hasRole('ROLE_USER')") | |||
There was a problem hiding this comment.
Technically user will never be able to get anything since they cant create one in the first place, not dangerous but its better if we just do has role driver
JosephLiCodes
force-pushed
the
driverAvailabilityControllerpt3
branch
from
4e25c36
to
cc7be1a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this pr, I added get all endpoint for driver availabilities controller.
DriverAvailabilityController
GET /api/driverAvailabilitythat gets all availability submissions for the current user.close #46