Driver Availability: Add controller GET by id endpoint for driver availability #57
+133
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JosephLiCodes
requested review from
scottpchow23,
andrewpengucsb,
AnikaArora,
sangitakunapuli,
tallyhawley,
Aasish-Virjala and
whuang602
as code owners
wzqd
changed the title
calee14
previously approved these changes
Mar 8, 2024
JosephLiCodes
force-pushed
the
driverAvailabilityControllerpt5
branch
2 times, most recently
from
e6c850f
to
c93527e
Compare
andrewpengucsb
requested changes
Mar 15, 2024
| } | ||
|
|
||
| @Operation(summary = "Get a single availability by id, if user owns it") | ||
| @PreAuthorize("hasRole('ROLE_USER')") |
There was a problem hiding this comment.
Same thing as last PR, user wont be able to get anything, better to just be ROLE_DRIVER even if just user is not dangerous
JosephLiCodes
force-pushed
the
driverAvailabilityControllerpt5
branch
from
c93527e
to
1307aed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this pr, I added the get by id endpoint for driver availability controller
DriverAvailabilityController
GET /api/driverAvailability?id=123that gets an availability submission if owned by the current user.close #45