-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
COMPLETED PR for Epic-School-and-Term-validations-F5 #43
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Deployment does not seem to reflect the change, I can still submit term values that do not strictly follow the format of the regex. While it is true that it works for edit, there is currently no regex enforcement for create.
…-cs156-w24/proj-organic-w24-6pm-2 into Epic-School-and-Term-validations-F5 needs to merge
I just implemented the term regex for create. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
When updating the term, the user must follow the regex format of the season followed by a 2 digit year. For ex. w24, s24, f24 or else it will display an error message. User also must update the term whenever editing the school as stated in #23
Closes #24
![Screenshot 2024-03-12 at 5 37 32 PM](https://private-user-images.githubusercontent.com/124760099/312272444-4a3bfa56-418b-443f-8738-e478db7fd7e7.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTgyNjMzMDMsIm5iZiI6MTcxODI2MzAwMywicGF0aCI6Ii8xMjQ3NjAwOTkvMzEyMjcyNDQ0LTRhM2JmYTU2LTQxOGItNDQzZi04NzM4LWU0NzhkYjdmZDdlNy5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwNjEzJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDYxM1QwNzE2NDNaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1jZDVkMmFjM2VjZjY1NTAzNzU3MDVmYzc1ZTBkNWZkZWU1ZGVlMzQ3M2RlMGEyNjQxZjdiNWFiNTFhMjZhMThhJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.l4qkgaC1mL2uDH8cJhZSl0dcrZnMsZO2ihiTG5O563w)
Deployed at: https://organic-thienanvuu-dev.dokku-10.cs.ucsb.edu