Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

COMPLETED PR for Epic-School-and-Term-validations-F5 #43

Closed
wants to merge 9 commits into from

Conversation

DemirInce
Copy link
Contributor

@DemirInce DemirInce commented Mar 7, 2024

When updating the term, the user must follow the regex format of the season followed by a 2 digit year. For ex. w24, s24, f24 or else it will display an error message. User also must update the term whenever editing the school as stated in #23

Closes #24
Deployed at: https://organic-thienanvuu-dev.dokku-10.cs.ucsb.edu
Screenshot 2024-03-12 at 5 37 32 PM

@thienanvuu thienanvuu changed the title Dummy PR for Epic-School-and-Term-validations-F5 PR for Epic-School-and-Term-validations-F5 Mar 12, 2024
kjlee2504
kjlee2504 previously approved these changes Mar 12, 2024
Copy link
Contributor

@kjlee2504 kjlee2504 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DemirInce DemirInce changed the title PR for Epic-School-and-Term-validations-F5 COMPLETED PR for Epic-School-and-Term-validations-F5 Mar 12, 2024
@whuang602 whuang602 added the 5 label Mar 13, 2024
Copy link
Contributor

@whuang602 whuang602 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deployment does not seem to reflect the change, I can still submit term values that do not strictly follow the format of the regex. While it is true that it works for edit, there is currently no regex enforcement for create.

Thienan Vu added 2 commits March 12, 2024 23:40
…-cs156-w24/proj-organic-w24-6pm-2 into Epic-School-and-Term-validations-F5

needs to merge
@thienanvuu
Copy link
Contributor

I just implemented the term regex for create.

@kjlee2504 kjlee2504 self-requested a review March 13, 2024 06:54
Copy link
Contributor

@kjlee2504 kjlee2504 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@whuang602 whuang602 closed this Mar 13, 2024
@whuang602 whuang602 removed the 5 label Mar 13, 2024
@DemirInce DemirInce reopened this Mar 13, 2024
@kjlee2504 kjlee2504 closed this Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EPIC: School and Term validations (F5: Frontend Course Form uses school specific regex.)
4 participants