BUG fixed: Course can end before it starts #69
+46
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanvo504
requested review from
scottpchow23,
andrewpengucsb,
AnikaArora,
sangitakunapuli,
tallyhawley,
Aasish-Virjala and
whuang602
as code owners
luxiangzh
requested changes
Mar 11, 2024
There was a problem hiding this comment.
Backend jacoco test not passed. See logs:
Warning: Rule violated for bundle organic: instructions covered ratio is 0.99, but expected minimum is 1.00
Warning: Rule violated for bundle organic: branches covered ratio is 0.97, but expected minimum is 1.00
Warning: Rule violated for bundle organic: lines covered ratio is 0.99, but expected minimum is 1.00
Error: Failed to execute goal org.jacoco:jacoco-maven-plugin:0.8.7:check (check) on project organic: Coverage checks have not been met. See log for details. -> [Help 1]
luxiangzh
previously approved these changes
Mar 12, 2024
src/main/java/edu/ucsb/cs156/organic/Interceptors/RoleUserInterceptor.java
Outdated
Show resolved
Hide resolved
luxiangzh
force-pushed
the
rv-CourseEndBug
branch
from
970ecd2
to
512362d
Compare
luxiangzh
force-pushed
the
rv-CourseEndBug
branch
from
512362d
to
06b252f
Compare
golo230
approved these changes
Mar 15, 2024
whuang602
requested changes
Mar 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the CoursesController API so that in post it checks if the endDate is after the startDate to ensure the endDate is AFTER the startDate
DEV deployment link: https://organic-rv.dokku-12.cs.ucsb.edu/
Closes #8