-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
t-5pm-c Refined Schedule #126
Open
kjuu0
wants to merge
15
commits into
master
Choose a base branch
from
t-5pm-c-refined-schedule
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkomarlu
requested changes
Mar 6, 2020
kjuu0
force-pushed
the
t-5pm-c-refined-schedule
branch
2 times, most recently
from
March 9, 2020 21:58
b7eabe6
to
4421f08
Compare
pconrad
added
the
Changes Requested
Code review has been done, and changes are needed before this can be merged
label
Mar 10, 2020
…tories, created new TimeSlotAssignmentController and an unfinished page
…Assignment for testing purposes
…urse then by last name
…ngle letter day representations
kjuu0
force-pushed
the
t-5pm-c-refined-schedule
branch
from
March 11, 2020 02:25
4a0ba2c
to
99b4d2f
Compare
tkomarlu
added
Ready for Mentor Review
and removed
Changes Requested
Code review has been done, and changes are needed before this can be merged
labels
Mar 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR:
Added a new page to search for Time Slot Assignments by quarter
Added a page to display search results
Sorted results by room, then by day, then by start time
Added a tutor list to results page to display list of tutors during a time slot assignment, including their course
Sorted tutor list by course offering ID, then by tutor last name