End to End tests #157
Open
End to End tests #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/main/resources/db/migration/V3_1__drop_appuser_name_col.sql
Outdated
Show resolved
Hide resolved
btk5h
requested changes
Jun 5, 2020
pconrad
requested changes
Jun 5, 2020
src/test/java/edu/ucsb/cs56/ucsb_open_lab_scheduler/end2end/AdminPageEnd2EndTest.java
Outdated
Show resolved
Hide resolved
| public class AdminPageEnd2EndTest { | ||
|
|
||
| static { | ||
| System.setProperty("spring.security.oauth2.client.provider.wiremock.authorization-uri", "http://localhost:8077/oauth/authorize"); |
There was a problem hiding this comment.
I wonder whether we should factor this out into a test helper class support method... basically everything in this static block...
There was a problem hiding this comment.
I think the factoring out is optional for merging.. but still a good idea...
| webDriver = new ChromeDriver(options); | ||
|
|
||
| // Configure mock oauth endpoints | ||
| mockOAuth2Provider.stubFor(get(urlPathEqualTo("/favicon.ico")).willReturn(notFound())); |
There was a problem hiding this comment.
This might also be a good candidate to be factored out into some kind of test helper...
src/test/java/edu/ucsb/cs56/ucsb_open_lab_scheduler/end2end/AdminPageEnd2EndTest.java
Outdated
Show resolved
Hide resolved
|
I need to check if both PRs work with Jacqui's changes to the DB migrations as the error in the tests at the moment is due to the migrations. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds end-to-end testing with selenium and a mock oauth provider. We also have additional seed data so that we can mock the login flow for an admin user. This PR also adds/modifies some ids for html elements to make them easier to find with Selenium tests