Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breadcrumbs and header update Fixes #272 #310

Merged
merged 7 commits into from Apr 10, 2024
Merged

Breadcrumbs and header update Fixes #272 #310

merged 7 commits into from Apr 10, 2024

Conversation

knice
Copy link
Member

@knice knice commented Apr 10, 2024

What does this do/fix?

New

  • Move breadcrumbs to a permanent location beneath the main navigation in all page templates
  • Adjust styles for breadcrumbs (slightly larger font, a11y-appropriate color, and link colors)
  • Last crumb is now the unlinked title of the current page
  • Remove the "with breadcrumbs" no title template
  • Modify space between crumbs and page title in both templates

Changes

  • Small typographic adjustment to the quote block styles
  • Soften the drop shadow beneath main nav
  • Balance typography of all headings with text-wrap: balance
  • Remove unused serif font declaration from the theme
  • Remove the unused logo switch function (deprecated when we added Truss header to the theme)

Links to relevant issues

Tests

  • Does your site pick up the changes to the "page-no-title" template? Breadcrumbs should appear there
  • Do all of the pages on your site display the crumbs in their new location?
  • What happens on a page that was previously using the "page-no-title-with-breadcrumbs" template? That template is deleted in this PR

@knice knice requested a review from Herm71 April 10, 2024 20:13
Copy link
Member

@Herm71 Herm71 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great!

@knice knice merged commit 5bd477c into main Apr 10, 2024
@knice knice deleted the knice/issue272 branch April 10, 2024 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants