Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sets functionality need for next() and hasnext() implementation #70

Open
simranbarnwal opened this issue May 28, 2022 · 3 comments
Open

Comments

@simranbarnwal
Copy link
Contributor

Hi,

Currently, the class set doesn't have any fields, and neither does it support adding parameters or returning something from it's functions (class set is not included in the type checking environment). We tried changing those yesterday but the amount of changes required is a lot and we don't want to change how the sets group are implementing their functionalities.

Can the sets group support the above so that we can add next() and hasnext() in the set.wat file. Or can they implement next() and hasnext() as they proposed in their next milestone? To implement a set iterator, we need to be unblocked on this.

Thanks! @jpolitz @yalhessi @7bw

@7bw
Copy link
Contributor

7bw commented May 28, 2022

Hi, sorry for the late reply. This was due to a miscommunication between the member who wrote the conflicts part with for loop and the member who wrote the next milestone. That's why we only included the interaction with your group in our conflicts doc but not in our next milestone. We will try to implement next() and hasnext() and will let you know when we finish. Thanks for bringing this up.

@7bw
Copy link
Contributor

7bw commented May 30, 2022

Hi, we have implemented firstItem(), next(), and hasnext() for your reference. Please see the details here: #69

@lmxtiger
Copy link
Contributor

If you are not sure how to use these 3 functions, feel free to check out the relevant test cases in tests/sets.test.ts or just let us know here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants