Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove liquid-base with automatic search of assumptions #2166

Merged
merged 27 commits into from Apr 27, 2023

Conversation

facundominguez
Copy link
Collaborator

@facundominguez facundominguez commented Apr 14, 2023

This PR

  • Moves and renames the liquidhaskell package to liquidhaskell-boot
  • Creates a new package liquidhaskell that reexports the plugin and additionally defines modules with assumptions for base and ghc-prim.
  • Has LH load assumptions from these modules whenever a target module imports any matching module.

Matching of modules is done solely by name. Whenever the target module imports module A.B.C, LH will try to load assumptions from module A.B.C_LHAssumptions in dependency packages. It cannot load assumptions automatically from the home package, but A.B.C_LHAssumptions can be imported manually as well.

This PR implements much of #2106. If the approach looks good, I will proceed to remove the remaining liquid-* packages and then I'll update the documentation.

@facundominguez
Copy link
Collaborator Author

facundominguez commented Apr 14, 2023

The commits are likely easier to explore individually than all together.
The most interesting commit must be 83cad3d and then 7d76971.

@facundominguez
Copy link
Collaborator Author

Looks like there is some speed up in CI with these changes. While circleci jobs in develop take 30 minutes. Jobs in this branch are closer to 20 minutes. I've also noticed some speed ups locally.

But I don't have insights about why. One factor could be that assumptions fit in 33 modules while the removed liquid-base holds more than 200 modules.

@ranjitjhala
Copy link
Member

ranjitjhala commented Apr 15, 2023 via email

@facundominguez facundominguez force-pushed the fd/remove-liquid-base2 branch 2 times, most recently from 3944be8 to 4e50845 Compare April 17, 2023 21:54
@facundominguez
Copy link
Collaborator Author

@nikivazou, @ranjitjhala, in the absence of objections, I would be merging this in a couple of days. Please, let me know if you'd like to offer more review time.

@ranjitjhala
Copy link
Member

ranjitjhala commented Apr 18, 2023 via email

@facundominguez
Copy link
Collaborator Author

Good idea!

@facundominguez facundominguez merged commit fc4a89b into develop Apr 27, 2023
6 of 10 checks passed
@facundominguez facundominguez deleted the fd/remove-liquid-base2 branch April 27, 2023 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants